-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What happens if demo files are updated and a user has already visited the site #11
Comments
Thanks @psychemedia. The way it works for now if the jupyterlite is able to fetch the initial content (generated via If new files are added to the repo and deployment, they should normally show up automatically. If a user opens one of these files, modifies it and save it, it will persist in local storage. Next time the page is loaded it will still be the user's copy. If they delete the file (for example with right-click), the file will revert to the original (generated with |
Maybe we should have some docs about this to help clarify. |
"If they delete the file (for example with right-click), the file will revert to the original (generated with --files)." So is this like some sort of "transparent mount", where a user can work in a "user layer" editing files etc but if they delete a file that was in edited user storage area it reappears from the provided/default files layer when they reload the environment. To clarify: if I edit, save and delete a provided/shipped file in a browser session, if I hard refresh the browser, the deleted file will reappear? If I just delete a shipped file without changing it, will it reappear after a reload too? Related are the semantics of the File menu options from an open notebook |
Normally it should be possible to test these scenarios and see what happens?
Not the deleted files, but the original shipped file should appear.
This should be like a no-op for now, and the file will still be visible in the file browser.
It's in the browser storage yes. It was added in jupyterlite/jupyterlite#47 and keeps 5 versions. |
This already caused confusion for me, too. I put up a site for my grad class using Jupyter Lite and GitHub pages, and when I updated the notebook via git, I kept getting the old version. I think this is a place that some notifications would be really helpful like:
It might also make sense to have a new menu item "Revert Notebook from Repository" or "Load Notebook from Repository" or similar; if it can specifically put "GitHub" instead of "Repository" when run from GitHub pages, that will be even more clear for users. It wasn't clear to me what disk that "Reload Notebook from Disk" referred to -- I thought it might get me the latest from the repository. |
If a user has visited the site from a particular browser and then revisits the demo site at a later time, perhaps noticing from the repo that additional demo examples have been added, or original examples have been updated, how will their browser respond?
How could a user "update" their local state to reflect the current repo live demo state? (I guess one way might be to run the browser as a new private browser session, but how many folk would think to do that?)
The text was updated successfully, but these errors were encountered: