-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REFACTOR]: [SQUARE] Add amount conversion framework to Square #6137
Comments
@ImSagnik007 can i work on this? |
@keshavkrishna Assigning this to issue. |
Hey @keshavkrishna , Quick check-in on the status of this issue. If you have any questions or need assistance, feel free to reach out in the community. |
@gorakhnathy7 I was facing issues with my set up, but I have resolved it now with the help of community members, I will working on this now. |
@gorakhnathy7 @ImSagnik007 I would like to work on this one if it's up for grab |
Hey @keshavkrishna Are you still working on the issue? |
Hii @gorakhnathy7, please assign it to someone. I won't be able to allocate bandwidth for this rn. I will pick another issue later. |
hii @gorakhnathy7 , can you assign this to me ? |
Hey @mrswastik-robot Assigned to you! |
I can pick this up if assignee is busy |
Hey @mrswastik-robot Are you still working on this issue? |
Hii @gorakhnathy7 , I am really sorry I was busy with something else. Can you give me a 2 day window for the PR , then you can assign it to other assignee |
hii @gorakhnathy7 , I have linked a PR to the issue, can you please review it, I will be happy to make requested code changes |
📝 Feature Description
Currently, amounts are represented as
i64
values throughout the application. We want to introduce aUnit
struct that explicitly states the denomination. A new type,MinorUnit
, has been added to standardize the flow of amounts across the application. This type will now be used by all the connector flows.Rather than handling conversions in each connector, we will centralize the conversion logic in one place within the core of the application.
🔨 Possible Implementation
convert
function to receive the amount in their required format.🔖 Note: All the changes needed should be contained within
hyperswitch/crates/router/src/connector/
,crates/router/src/types/api.rs
,crates/router/tests/connectors/
📦 Have you spent some time checking if this feature request has been raised before?
📦 Have you read the Contributing Guidelines?
✨ Are you willing to submit a PR?
Submission Process:
Refer here for Terms and conditions for the contest.
The text was updated successfully, but these errors were encountered: