Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR]: [SQUARE] Add amount conversion framework to Square #6137

Open
2 tasks
ImSagnik007 opened this issue Sep 26, 2024 · 13 comments · May be fixed by #6566
Open
2 tasks

[REFACTOR]: [SQUARE] Add amount conversion framework to Square #6137

ImSagnik007 opened this issue Sep 26, 2024 · 13 comments · May be fixed by #6566
Assignees
Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants

Comments

@ImSagnik007
Copy link
Contributor

📝 Feature Description

Currently, amounts are represented as i64 values throughout the application. We want to introduce a Unit struct that explicitly states the denomination. A new type, MinorUnit, has been added to standardize the flow of amounts across the application. This type will now be used by all the connector flows.

Rather than handling conversions in each connector, we will centralize the conversion logic in one place within the core of the application.

🔨 Possible Implementation

  • For each connector, we need to create an amount conversion function. Connectors will specify the format they require, and the core framework will handle the conversion accordingly.
  • Connectors should invoke the convert function to receive the amount in their required format.
  • Refer to the connector documentation to determine the required amount format for each connector.
  • You can refer this PR for more context.

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/ , crates/router/src/types/api.rs , crates/router/tests/connectors/

📦 Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

📦 Have you read the Contributing Guidelines?

✨ Are you willing to submit a PR?

Submission Process:

  • Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
  • Once assigned, submit a pull request (PR).
  • Maintainers will review and provide feedback, if any.
  • Maintainers can unassign issues due to inactivity, read more here.

Refer here for Terms and conditions for the contest.

@ImSagnik007 ImSagnik007 added A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Sep 26, 2024
@keshavkrishna
Copy link

@ImSagnik007 can i work on this?

@gorakhnathy7
Copy link
Collaborator

@keshavkrishna Assigning this to issue.

@gorakhnathy7
Copy link
Collaborator

Hey @keshavkrishna ,

Quick check-in on the status of this issue. If you have any questions or need assistance, feel free to reach out in the community.

@keshavkrishna
Copy link

@gorakhnathy7 I was facing issues with my set up, but I have resolved it now with the help of community members, I will working on this now.

@mrswastik-robot
Copy link

@gorakhnathy7 @ImSagnik007 I would like to work on this one if it's up for grab

@gorakhnathy7
Copy link
Collaborator

Hey @keshavkrishna Are you still working on the issue?

@keshavkrishna
Copy link

Hii @gorakhnathy7, please assign it to someone. I won't be able to allocate bandwidth for this rn. I will pick another issue later.

@mrswastik-robot
Copy link

hii @gorakhnathy7 , can you assign this to me ?

@gorakhnathy7
Copy link
Collaborator

Hey @mrswastik-robot Assigned to you!

@AnishKacham
Copy link
Contributor

I can pick this up if assignee is busy

@gorakhnathy7
Copy link
Collaborator

Hey @mrswastik-robot Are you still working on this issue?

@mrswastik-robot
Copy link

Hey @mrswastik-robot Are you still working on this issue?

Hii @gorakhnathy7 , I am really sorry I was busy with something else. Can you give me a 2 day window for the PR , then you can assign it to other assignee

@mrswastik-robot
Copy link

hii @gorakhnathy7 , I have linked a PR to the issue, can you please review it, I will be happy to make requested code changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants