tests: don't run unmanageddetector tests in parallel

justinsb · justinsb · commit 03be86ce7758 · 2025-05-17T08:39:20.000-04:00
These currently share a kube apiserver,
and check whether a statefulset is running,
but one of them starts the statefulset.
We can't run them in parallel.
diff --git a/pkg/controller/unmanageddetector/controller_test.go b/pkg/controller/unmanageddetector/controller_test.go
@@ -47,7 +47,6 @@ var (
 )
 
 func TestReconcile_UnmanagedResource(t *testing.T) {
-	t.Parallel()
 	testID := testvariable.NewUniqueID()
 	client := mgr.GetClient()
 	testcontroller.EnsureNamespaceExistsT(t, client, k8s.SystemNamespace)
@@ -89,7 +88,6 @@ func TestReconcile_UnmanagedResource(t *testing.T) {
 }
 
 func TestReconcile_ManagedResource(t *testing.T) {
-	t.Parallel()
 	testID := testvariable.NewUniqueID()
 	client := mgr.GetClient()
 	testcontroller.EnsureNamespaceExistsT(t, client, k8s.SystemNamespace)

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,6 @@ var (`
`47`	`47`	`)`
`48`	`48`
`49`	`49`	`func TestReconcile_UnmanagedResource(t *testing.T) {`
`50`		`- t.Parallel()`
`51`	`50`	`testID := testvariable.NewUniqueID()`
`52`	`51`	`client := mgr.GetClient()`
`53`	`52`	`testcontroller.EnsureNamespaceExistsT(t, client, k8s.SystemNamespace)`
`@@ -89,7 +88,6 @@ func TestReconcile_UnmanagedResource(t *testing.T) {`
`89`	`88`	`}`
`90`	`89`
`91`	`90`	`func TestReconcile_ManagedResource(t *testing.T) {`
`92`		`- t.Parallel()`
`93`	`91`	`testID := testvariable.NewUniqueID()`
`94`	`92`	`client := mgr.GetClient()`
`95`	`93`	`testcontroller.EnsureNamespaceExistsT(t, client, k8s.SystemNamespace)`