JAVA_HOME ignored on MacOS/Darwin

[lionello]

Actual

I have JAVA_HOME environment variable set to the path of a valid JDK, but locate-java-home does not find it.

Expected

The value of JAVA_HOME should always be considered a reasonable candidate when checking for a valid java-home.

Root cause

Turns out on MacOS only the output of /usr/libexec/java_home is used and that one ignores whatever is in JAVA_HOME.

Fix

Add this snippet from linux.ts to darwin.ts line 22:

    // Option 2: Is JAVA_HOME defined?
    // (NOTE: locate_java_home will prune redundancies.)
    if (process.env.JAVA_HOME) {
      installations.push(process.env.JAVA_HOME!);
    }

[hedefalk]

I'm using Nix to manage java installations. This project is a transitive dependency on my toolchain and fails because it doesn't honor JAVA_HOME.

❯ npx locate-java-home                                                                                                                                           
npx: installed 4 in 1.996s
JAVA_HOME directories found: 

❯ echo $JAVA_HOME
env-/nix/store/7gxklxmf8d2c15jmw3i9l67kd2zci3w5-adoptopenjdk-hotspot-bin-11.0.10

locate-java-home/ts/lib/platforms/darwin.ts

Line 7 in 6f6e5a4

exec('/usr/libexec/java_home -V', (err: Error | null, stdout: Buffer | string, stderr: Buffer | string) => {

calls:

❯ /usr/libexec/java_home -V                                                                                                                                       
The operation couldn’t be completed. Unable to locate a Java Runtime.
Please visit http://www.java.com for information on installing Java.