Skip to content

Related issues about HMAC key length and RSA key length in JWS #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZupeiNie opened this issue Apr 3, 2025 · 2 comments
Closed

Related issues about HMAC key length and RSA key length in JWS #668

ZupeiNie opened this issue Apr 3, 2025 · 2 comments

Comments

@ZupeiNie
Copy link

ZupeiNie commented Apr 3, 2025

Hi, We are a research group dedicated to helping developers build secure applications. We have developed a cryptographic misuse detector that focuses on the secure implementation and use of JSON Web Tokens (JWT). While analyzing your impressive public repository, our detector identified several security concerns.
Specifically, we found that the HMAC and RSA key lengths used in your JSON Web Signature (JWS) implementation do not meet recommended security standards(RFC 7518、NIST SP800-117、RFC 2437). According to CWE-326 (Inadequate Encryption Strength), using keys that are too short can lead to serious vulnerabilities and potential attacks.
We kindly suggest reviewing and updating the key lengths to ensure that your cryptographic implementations adhere to best practices and maintain robust security.
Thank you for your attention.

@anakinj
Copy link
Member

anakinj commented Apr 7, 2025

Hi,

Thank you for your generic message. Could you be a bit more specific what you are referring to.

The algo implementations are not enforcing any key lengths (except the RSA/PS algo that requires a key >= 2048 bits)

@anakinj
Copy link
Member

anakinj commented Apr 20, 2025

Im going to close this as the keysize is not something that is enforced by this library. Currently more recent version sof OpenSSL is enforcing some key sizes and those restrictions apply the users of this gem also.

@anakinj anakinj closed this as completed Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants