Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates on complex airgapped controller+worker are broken in some cases #5258

Open
4 tasks done
makhov opened this issue Nov 14, 2024 · 0 comments · May be fixed by #5260
Open
4 tasks done

Updates on complex airgapped controller+worker are broken in some cases #5258

makhov opened this issue Nov 14, 2024 · 0 comments · May be fixed by #5260
Labels
bug Something isn't working

Comments

@makhov
Copy link
Contributor

makhov commented Nov 14, 2024

Before creating an issue, make sure you've checked the following:

  • You are running the latest released version of k0s
  • Make sure you've searched for existing issues, both open and closed
  • Make sure you've searched for PRs too, a fix might've been merged already
  • You're looking at docs for the released version, "main" branch docs are usually ahead of released versions.

Platform

any

Version

v1.30.2+k0s

Sysinfo

`k0s sysinfo`
➡️ Please replace this text with the output of `k0s sysinfo`. ⬅️

What happened?

I trying to update the air-gapped cluster by creating a new controller and removing the old one. But the old controller generates clusterconfig and lists all the images explicitly, so the new one also tries to use them and fails.

Steps to reproduce

  1. Create a cluster with --enable-dynamic-config and --enable-worker, k0s v1.29.* and k0s config like this
  spec:
    images:
      default_pull_policy: Never
    network:
      nodeLocalLoadBalancer: 
        enabled: true
  1. Create a new machine with k0s v1.30.* and join the cluster
  2. Once the machine joins the cluster it will try to get the old image versions, since they are listed in the dynamic config

Expected behavior

The new machine uses a new images

Actual behavior

The new machine uses old images

Screenshots and logs

No response

Additional context

The reason for this is that we check and strip default values in the config inaccurately:
https://github.com/k0sproject/k0s/blob/main/pkg/apis/k0s/v1beta1/clusterconfig_types.go#L98

@makhov makhov added the bug Something isn't working label Nov 14, 2024
@makhov makhov linked a pull request Nov 15, 2024 that will close this issue
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant