Skip to content

fix: error on distros without VERSION_ID on /etc/os-release #12440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2025

Conversation

yulken
Copy link
Contributor

@yulken yulken commented Jun 4, 2025

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

@yulken yulken requested a review from a team as a code owner June 4, 2025 20:02
@brandond
Copy link
Member

brandond commented Jun 4, 2025

What distro has an os-release file with no VERSION_ID?

@yulken
Copy link
Contributor Author

yulken commented Jun 4, 2025

@brandond I've linked an issue where this behavior was detected.

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.91%. Comparing base (b33b713) to head (4069af0).
Report is 2 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (b33b713) and HEAD (4069af0). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (b33b713) HEAD (4069af0)
e2etests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #12440       +/-   ##
===========================================
- Coverage   40.56%   19.91%   -20.65%     
===========================================
  Files         187      184        -3     
  Lines       19286    19221       -65     
===========================================
- Hits         7823     3828     -3995     
- Misses      10275    14962     +4687     
+ Partials     1188      431      -757     
Flag Coverage Δ
e2etests ?
unittests 19.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brandond
Copy link
Member

brandond commented Jun 5, 2025

No backports necessary for install script changes.

@brandond brandond merged commit b8cf676 into k3s-io:master Jun 5, 2025
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants