Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the genre column be more consistent? #236

Open
samuele-mattiuzzo opened this issue Dec 24, 2019 · 4 comments
Open

Should the genre column be more consistent? #236

samuele-mattiuzzo opened this issue Dec 24, 2019 · 4 comments

Comments

@samuele-mattiuzzo
Copy link
Contributor

This is more of a question with a potential follow-up suggestion: in the genre column, we do have drama/thriller and thriller/drama

Is there a valid reason behind this? If not, I would suggest making it more consistent (eg: pick one between the two and use it consistently across the list), so that sorting it properly groups them.

Also: since we do have categories already, why the column at all? It seems redundant to me, I would maybe instead replace that with a different rating source maybe (rotten tomatoes?)

@k4m4
Copy link
Owner

k4m4 commented Feb 17, 2020

I agree with both your suggestions @samuele-mattiuzzo. I'll put this issue up for grabs. Let's focus on getting rid of the categories column for now and consider adding a different rating source in a new issue.

@samuele-mattiuzzo
Copy link
Contributor Author

Happy to take care of this, fancy assigning it to me? I'll clean up all the discrepancies and pick one of either (as I suspect order of tags/categories doesn't truly matter)

@liam53
Copy link

liam53 commented Dec 11, 2021

How do you hack can you tell me

@liam53
Copy link

liam53 commented Dec 11, 2021

How do you hack prodigy sorry for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants