Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Flatpak Version #1224

Open
crimsonthunder opened this issue Nov 9, 2024 · 2 comments
Open

Request: Flatpak Version #1224

crimsonthunder opened this issue Nov 9, 2024 · 2 comments
Labels
component:Packaging Packaging related issue state:Backlog This issue will be worked on in the future type:Enhancement New feature or request

Comments

@crimsonthunder
Copy link

Hello, and thank you for the fantastic work on Video2x! I truly appreciate the time and effort put into making this app.

Would it be possible to create a Flatpak version of Video2x? A Flatpak version would be incredibly helpful, as it allows for easier installation, and compatibility across different Linux distributions. This could make Video2x more accessible to a broader range of linux users and simplify updates as well.

Thank you very much for considering this request and thank you again for your hard work.

@github-actions github-actions bot added the state:Backlog This issue will be worked on in the future label Nov 9, 2024
@k4yt3x
Copy link
Owner

k4yt3x commented Nov 9, 2024

Interesting suggestion. It may also be easier to recommend flatpak than asking people to use the Docker image. I'll look into it to see how hard it is to make a flatpak package. If it's not too difficult maybe I could release flatpak or AppImage instead of deb files only for Ubuntu.

@k4yt3x k4yt3x added type:Enhancement New feature or request component:Packaging Packaging related issue labels Nov 9, 2024
@k4yt3x
Copy link
Owner

k4yt3x commented Nov 10, 2024

I gave it a try, ran into some issues:

image

app-id: com.github.k4yt3x.video2x
runtime: org.freedesktop.Platform
runtime-version: "23.08"
sdk: org.freedesktop.Sdk
command: video2x
finish-args:
  - --share=network
  - --share=ipc
  - --socket=x11
  - --socket=wayland
  - --device=dri
  - --env=LD_LIBRARY_PATH=/app/lib

modules:
  - name: video2x
    buildsystem: cmake
    builddir: true
    config-opts:
      - -DUSE_SYSTEM_OPENCV=OFF
      - -DUSE_SYSTEM_NCNN=OFF
      - -DUSE_SYSTEM_SPDLOG=OFF
      - -DUSE_SYSTEM_BOOST=OFF
    sources:
      - type: git
        url: https://github.com/k4yt3x/video2x.git
        branch: master
        submodules: true

cleanup:
  - /include
  - /share/man
  - /share/doc
  - /share/gtk-doc

I'll just leave this here for now for anyone experienced with Flatpak to try. I'll probably get back to this after implementing frame interpolation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:Packaging Packaging related issue state:Backlog This issue will be worked on in the future type:Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants