From 4ecd17930d091a2e8209f591b80cad4cf00257e6 Mon Sep 17 00:00:00 2001
From: jmcardon <cardona.josem@gmail.com>
Date: Tue, 12 Nov 2024 15:05:21 -0500
Subject: [PATCH] fix with-read desugaring to use pattern guard

---
 pact/Pact/Core/Serialise/LegacyPact.hs | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/pact/Pact/Core/Serialise/LegacyPact.hs b/pact/Pact/Core/Serialise/LegacyPact.hs
index 3e597ff4..cf655cae 100644
--- a/pact/Pact/Core/Serialise/LegacyPact.hs
+++ b/pact/Pact/Core/Serialise/LegacyPact.hs
@@ -1,6 +1,7 @@
 -- |
 {-# LANGUAGE ScopedTypeVariables  #-}
 {-# LANGUAGE CPP #-}
+{-# LANGUAGE PatternGuards #-}
 {-# LANGUAGE TemplateHaskell #-}
 
 module Pact.Core.Serialise.LegacyPact
@@ -621,36 +622,28 @@ fromLegacyTerm mh = \case
     fn' <- fromLegacyTerm mh fn
     case fn' of
       Builtin b _ -> case b of
-        CoreBind -> case args of
-          [bObj, Legacy.TBinding bps scope _] -> do
+        CoreBind | [bObj, Legacy.TBinding bps scope _] <- args -> do
             bObj' <- fromLegacyTerm mh bObj
             lam <- objBindingToLet mh bps scope
             pure (App fn' [bObj', lam] ())
 
-          _ -> throwError $ "invariant failure: CoreBind"
-        CoreWithRead -> case args of
-          [tbl, rowkey, Legacy.TBinding bps scope _] -> do
+        CoreWithRead | [tbl, rowkey, Legacy.TBinding bps scope _] <- args -> do
             tbl' <- fromLegacyTerm mh tbl
             rowkey' <- fromLegacyTerm mh rowkey
             lam <- objBindingToLet mh bps scope
             pure (App fn' [tbl', rowkey', lam] ())
 
-          _ -> throwError "invariant failure: CoreWithRead"
-        CoreWithDefaultRead -> case args of
-          [tbl, rowkey, defaultObj, Legacy.TBinding bps scope _] -> do
+        CoreWithDefaultRead | [tbl, rowkey, defaultObj, Legacy.TBinding bps scope _] <- args -> do
             tbl' <- fromLegacyTerm mh tbl
             rowkey' <- fromLegacyTerm mh rowkey
             defaultObj' <- fromLegacyTerm mh defaultObj
             lam <- objBindingToLet mh bps scope
             pure (App fn' [tbl', rowkey', defaultObj', lam] ())
 
-          _ -> throwError "invariant failure: CoreWithDefaultRead"
-        CoreResume -> case args of
-          [Legacy.TBinding bps scope _] -> do
+        CoreResume | [Legacy.TBinding bps scope _] <- args -> do
             lam <- objBindingToLet mh bps scope
             pure (App fn' [lam] ())
 
-          _ -> throwError "invariant failure: CoreWithRead"
         -- [HOF Translation]
         -- Note: The following sections of translation are explained as follows:
         -- we transform, for example `(map (+ k) other-arg)` into