Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.browserify issue with meteor 1.3 beta.16 and above #30

Open
cstrat opened this issue Mar 16, 2016 · 6 comments
Open

client.browserify issue with meteor 1.3 beta.16 and above #30

cstrat opened this issue Mar 16, 2016 · 6 comments

Comments

@cstrat
Copy link

cstrat commented Mar 16, 2016

kadirahq/flow-router#552
^ Same issue as experienced here.

=> Started proxy.                             
=> Started MongoDB.                           
=> Errors prevented startup:                  

While processing files with cosmos:browserify (for target web.browser):
packages/kadira:flow-router/client.browserify.js: Arguments to path.resolve must be strings

Browserify options:
>  undefined
packages/kadira:dochead/package.browserify.js: Arguments to path.resolve must be strings

Browserify options:
>  undefined
@kokjinsam
Copy link

I wonder if it's the same issue. I got this error instead:

=> Errors prevented startup:                  

   While processing files with cosmos:browserify (for target web.browser):
   packages/kadira:dochead/package.browserify.js: Cannot find module 'load-script' from
   '/home/skaxwng/code/clean-mantra-webpack'

=> Your application has errors. Waiting for file change.

@arunoda
Copy link
Contributor

arunoda commented Mar 17, 2016

We need to remove the browserify package. We did it with the FlowRouter. Will do a fix soon.

@cstrat
Copy link
Author

cstrat commented Mar 17, 2016

Is any sort of hot fix for the time being?

@arunoda
Copy link
Contributor

arunoda commented Mar 17, 2016

For now, you have to remove browserify manually from this project and remove this file: https://github.com/kadirahq/meteor-dochead/blob/master/package.browserify.js

@JeremySaks
Copy link

Just a note after upgrading to 1.3 with dochead still included and unaltered, Meteor now starts with the message:

Unable to resolve some modules:

  "load-script" in /Users/jeremysaks/.meteor/packages/kadira_dochead/.1.4.0.1gp2m0m++os+web.browser+web.cordova/web.browser/package.browserify.js
(web.browser)

Consider running: meteor npm install --save load-script

The startup completes and the meta tags are correctly set, so I'm wondering if the advice is still to manually patch the package. Any reason not to leave it alone until a fix is released?

@arunoda
Copy link
Contributor

arunoda commented Apr 17, 2016

Merged #32 and this should be fixed by now properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants