Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit cc01a5c

Browse files
committedFeb 3, 2025·
feat(LDAP): add integration tests for LDAP Authorization
closes #782
1 parent a1c83b8 commit cc01a5c

File tree

2 files changed

+7
-17
lines changed

2 files changed

+7
-17
lines changed
 

‎api/src/test/java/io/kafbat/ui/OpenLdapPIntegrationTest.java

+7-14
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import static org.junit.jupiter.api.Assertions.assertNotNull;
77
import static org.junit.jupiter.api.Assertions.assertTrue;
88

9+
import io.kafbat.ui.api.model.Action;
910
import io.kafbat.ui.container.OpenLdapContainer;
1011
import io.kafbat.ui.model.AuthenticationInfoDTO;
1112
import io.kafbat.ui.model.ResourceTypeDTO;
@@ -60,26 +61,19 @@ public void testUserPermissions() {
6061

6162
assertNotNull(info);
6263
assertTrue(info.getRbacEnabled());
63-
System.out.println("info = " + info);
6464
List<UserPermissionDTO> permissions = info.getUserInfo().getPermissions();
6565
assertFalse(permissions.isEmpty());
6666
assertTrue(permissions.stream().anyMatch(permission ->
67-
permission.getClusters().contains(LOCAL) && permission.getResource() == ResourceTypeDTO.TOPIC));
67+
permission.getClusters().contains(LOCAL)
68+
&& permission.getResource() == ResourceTypeDTO.TOPIC
69+
&& permission.getActions().stream()
70+
.allMatch(action -> Action.fromValue(action.getValue()) != Action.ALL)
71+
)
72+
);
6873
assertEquals(permissions, authenticationInfo("johnwick").getUserInfo().getPermissions());
6974
assertEquals(permissions, authenticationInfo("jacksmith").getUserInfo().getPermissions());
7075
}
7176

72-
@Test
73-
public void testDirectUserPermissions() {
74-
AuthenticationInfoDTO info = authenticationInfo("jacksmith");
75-
76-
assertNotNull(info);
77-
assertTrue(info.getRbacEnabled());
78-
System.out.println("info = " + info);
79-
List<UserPermissionDTO> permissions = info.getUserInfo().getPermissions();
80-
assertFalse(permissions.isEmpty());
81-
}
82-
8377
@Test
8478
public void testEmptyPermissions() {
8579
assertTrue(Objects.requireNonNull(authenticationInfo("johnjames"))
@@ -123,7 +117,6 @@ public static class Initializer implements ApplicationContextInitializer<Configu
123117
@Override
124118
public void initialize(ConfigurableApplicationContext context) {
125119
System.setProperty("spring.ldap.urls", LDAP_CONTAINER.getLdapUrl());
126-
System.setProperty("oauth2.ldap.activeDirectory", "false");
127120
}
128121
}
129122
}

‎api/src/test/resources/application-rbac-ldap.yml

-3
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@ spring:
66
user-filter-search-base: "dc=kafbat,dc=io"
77
user-filter-search-filter: "(&(uid={0})(objectClass=inetOrgPerson))"
88
group-filter-search-base: "ou=people,dc=kafbat,dc=io" # required for RBAC
9-
oauth2:
10-
ldap:
11-
activeDirectory: false
129
logging:
1310
level:
1411
root: info

0 commit comments

Comments
 (0)