add umount to cleanup stack just if mount succeeded (#888)

romario-07 · web-flow · commit 7087ed136e78 · 2025-07-30T08:00:04.000Z
diff --git a/pkg/action/upgrade.go b/pkg/action/upgrade.go
@@ -176,8 +176,9 @@ func (u *UpgradeAction) Run() (err error) {
 			umount, err = e.MountRWPartition(persistentPart)
 			if err != nil {
 				u.config.Logger.Warnf("could not mount persistent partition: %s", err.Error())
+			} else {
+				cleanup.Push(umount)
 			}
-			cleanup.Push(umount)
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -176,8 +176,9 @@ func (u *UpgradeAction) Run() (err error) {`
`176`	`176`	`umount, err = e.MountRWPartition(persistentPart)`
`177`	`177`	`if err != nil {`
`178`	`178`	`u.config.Logger.Warnf("could not mount persistent partition: %s", err.Error())`
	`179`	`+ } else {`
	`180`	`+ cleanup.Push(umount)`
`179`	`181`	`}`
`180`		`- cleanup.Push(umount)`
`181`	`182`	`}`
`182`	`183`	`}`
`183`	`184`