Fix error message when no stable versions are found

Signed-off-by: Dimitris Karakasilis <[email protected]>

Author: jimmykarily

.github/public-cloud/cleanup-old-images-aws.sh

@@ -69,27 +69,30 @@ snapshotDeleteIfNotInVersionList() {
 
 s3ObjectDeleteIfNotInVersionList() {
   local bucket=$1
-  local key=$2
+  local objectKey=$2
   shift 2
   local versionList=("$@")
 
   # Get all S3 object tags and properly parse them
   TagExists=false
-  while IFS=$'\t' read -r key value; do
-    if [[ "$key" == "KairosVersion" ]]; then
-      for tagToCheck in "${versionList[@]}"; do
-        if [[ "$value" == "$tagToCheck" ]]; then
-          echo "S3 object '$key' in bucket '$bucket' has the '$tagToCheck' tag. Skipping cleanup."
-          TagExists=true
-          break 2
-        fi
-      done
-    fi
-  done < <(AWSNR s3api get-object-tagging --bucket "$bucket" --key "$key" --query 'TagSet[].[Key,Value]' --output text)
+  # Check if the object has any tags first
+  if AWSNR s3api get-object-tagging --bucket "$bucket" --key "$objectKey" --query 'length(TagSet)' --output text 2>/dev/null | grep -q '^[0-9]'; then
+    while IFS=$'\t' read -r tagKey tagValue; do
+      if [[ "$tagKey" == "KairosVersion" ]]; then
+        for tagToCheck in "${versionList[@]}"; do
+          if [[ "$tagValue" == "$tagToCheck" ]]; then
+            echo "S3 object '$objectKey' in bucket '$bucket' has the '$tagToCheck' tag. Skipping cleanup."
+            TagExists=true
+            break 2
+          fi
+        done
+      fi
+    done < <(AWSNR s3api get-object-tagging --bucket "$bucket" --key "$objectKey" --query 'TagSet[].[Key,Value]' --output text)
+  fi
 
   if [ "$TagExists" = false ]; then
-    AWSNR s3api delete-object --bucket "$bucket" --key "$key"
-    echo "S3 object $key in bucket $bucket deleted because it does not match any of the versions: '${versionList[*]}'."
+    AWSNR s3api delete-object --bucket "$bucket" --key "$objectKey"
+    echo "S3 object $objectKey in bucket $bucket deleted because it does not match any of the versions: '${versionList[*]}'."
   fi
 }