Handle not alphadigital chars in verbose name, fixes #32

Author: kalekseev

src/extra_checks/checks/model_field_checks.py

@@ -87,6 +87,14 @@ def apply(
 class CheckFieldVerboseNameGettextCase(GetTextMixin, CheckModelField):
     Id = CheckId.X052
 
+    @classmethod
+    def is_invalid(cls, value: object) -> bool:
+        return bool(
+            value
+            and isinstance(value, str)
+            and any(w != w.lower() and w != w.upper() for w in value.split(" "))
+        )
+
     def apply(
         self, field: models.fields.Field, ast: FieldASTProtocol, **kwargs: Any
     ) -> Iterator[django.core.checks.CheckMessage]:
@@ -96,13 +104,7 @@ def apply(
             and verbose_name.callable_func_name == self.gettext_func
         ):
             value = verbose_name.get_call_first_args()
-            if (
-                value
-                and isinstance(value, str)
-                and not all(
-                    w.islower() or w.isupper() or w.isdigit() for w in value.split(" ")
-                )
-            ):
+            if self.is_invalid(value):
                 yield self.message(
                     "Words in verbose name must be all upper case or all lower case.",
                     hint=f'Change verbose name to "{value.lower()}".',

tests/test_model_field_checks.py

@@ -59,6 +59,17 @@ def test_check_field_verbose_name_gettext_case(test_case):
     }
 
 
+def test_check_field_verbose_name_gettext_check_case():
+    is_invalid = model_field_checks.CheckFieldVerboseNameGettextCase.is_invalid
+    assert is_invalid("Abc Def")
+    assert not is_invalid("abc def")
+    assert not is_invalid("ABC def")
+    assert not is_invalid("ABC DEF")
+    assert not is_invalid("abc123 ABC123")
+    assert is_invalid("Abc123 AbC123")
+    assert not is_invalid("abc / def")
+
+
 def test_check_field_null_boolean(test_case):
     messages = (
         test_case.models(models.ModelFieldNullFalse)