Skip to content

Commit a3e5636

Browse files
committed
Drop support for django < 4.2
1 parent ed9df08 commit a3e5636

File tree

5 files changed

+6
-39
lines changed

5 files changed

+6
-39
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,13 @@ jobs:
2121
# https://github.com/actions/python-versions/blob/main/versions-manifest.json
2222
python-version: [3.8, 3.9, "3.10", "3.11", "3.12.0-rc.3"]
2323
django-version:
24-
- "Django>=3.2,<4.0"
25-
- "Django>=4.1,<4.2"
2624
- "Django>=4.2,<5.0"
2725
- "Django>=5.0a1,<5.1"
2826
# - "https://github.com/django/django/archive/main.tar.gz"
2927
include:
3028
- drf: djangorestframework
3129
python-version: "3.11"
32-
django-version: "Django<4.2,>=4.1" # must be different from django-version
33-
- django-version: "Django<4.0,>=3.2"
34-
python-version: 3.7
30+
django-version: "Django<5.0,>=4.2" # must be different from django-version
3531
exclude:
3632
- django-version: "Django>=5.0a1,<5.1"
3733
python-version: 3.8

CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,10 @@
22

33
### Unreleased
44

5-
- Drop python 3.6 support
5+
- Remove `field-boolean-null`
6+
- Deprecate `no-index-together`
7+
- Drop support for python < 3.8
8+
- Drop support for django < 4.2
69

710
### 0.13.3
811

src/extra_checks/check_id.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class CheckId(str, enum.Enum):
1515
X053 = "field-help-text-gettext"
1616
X054 = "field-file-upload-to"
1717
X055 = "field-text-null"
18-
X056 = "field-boolean-null"
18+
# X056 = "field-boolean-null" - removed
1919
X057 = "field-null"
2020
X058 = "field-foreign-key-db-index"
2121
X059 = "field-default-null"

src/extra_checks/checks/model_field_checks.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -163,24 +163,6 @@ def apply(
163163
)
164164

165165

166-
@registry.register(django.core.checks.Tags.models)
167-
class CheckFieldNullBoolean(CheckModelField):
168-
Id = CheckId.X056
169-
deprecation_warnings = [
170-
"`field-boolean-null` check is deprecated and will be removed in version 0.14.0"
171-
]
172-
173-
def apply(
174-
self, field: models.fields.Field, **kwargs: Any
175-
) -> Iterator[django.core.checks.CheckMessage]:
176-
if isinstance(field, models.NullBooleanField):
177-
yield self.message(
178-
f'Field "{field.name}" should be `BooleanField` with attribute `null=True`.',
179-
hint="Replace `NullBooleanField` by `BooleanField` with attribute `null=True`.",
180-
obj=field,
181-
)
182-
183-
184166
@registry.register(django.core.checks.Tags.models)
185167
class CheckFieldNullFalse(CheckModelField):
186168
Id = CheckId.X057

tests/test_model_field_checks.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -70,20 +70,6 @@ def test_check_field_verbose_name_gettext_check_case():
7070
assert not is_invalid("abc / def")
7171

7272

73-
def test_check_field_null_boolean(test_case):
74-
messages = (
75-
test_case.models(models.ModelFieldNullFalse)
76-
.settings({"checks": [model_field_checks.CheckFieldNullBoolean.Id.value]})
77-
.check(model_field_checks.CheckFieldNullBoolean)
78-
.run()
79-
)
80-
assert len(messages) == 1
81-
assert messages[0].id == model_field_checks.CheckFieldNullBoolean.Id.name
82-
assert {m.obj.name for m in messages} == {
83-
"null_fail",
84-
}
85-
86-
8773
def test_check_field_help_text_gettext(test_case):
8874
messages = (
8975
test_case.settings(

0 commit comments

Comments
 (0)