fix(drf-serializer): IndexError on missing Meta attr, closes #34

Author: kalekseev

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ### Unreleased
 
+### 0.14.1
+
+- fix(drf-serializer): IndexError on missing Meta attr, closes #34
+
 ### 0.14.0
 
 - Remove `field-boolean-null`

src/extra_checks/checks/drf_serializer_checks.py

@@ -64,7 +64,7 @@ def _get_line(self) -> Optional[int]:
                 ),
                 key=lambda a: a[1].find("class Meta"),
             )[0][0]
-        except StopIteration:
+        except (StopIteration, IndexError):
             return None
 
 

tests/example/serializers.py

@@ -9,6 +9,10 @@ class Meta:
         read_only_fields: list = []
 
 
+class InheritedArticleSerializer(ArticleSerializer):
+    pass
+
+
 class AuthorSerializer(serializers.ModelSerializer):
     first_name = serializers.CharField()
 
@@ -17,6 +21,10 @@ class Meta:
         extra_kwargs = {"first_name": {"read_only": True}}
 
 
+class InheritedAuthorSerializer(AuthorSerializer):
+    pass
+
+
 class DisableCheckSerializer(serializers.ModelSerializer):
     first_name = serializers.CharField()
 

tests/test_drf_serializer_checks.py

@@ -15,6 +15,8 @@
     ArticleSerializer,
     AuthorSerializer,
     DisableCheckSerializer,
+    InheritedArticleSerializer,
+    InheritedAuthorSerializer,
 )
 
 
@@ -37,25 +39,27 @@ def test_model_serializer_extra_kwargs(test_case):
 
 
 def test_model_serializer_meta_attribute(test_case):
-    messages = (
-        test_case.settings(
-            {
-                "checks": [
-                    {
-                        "id": CheckDRFSerializerMetaAttribute.Id.value,
-                        "attrs": ["read_only_fields"],
-                    }
-                ]
-            }
-        )
-        .check(CheckDRFSerializerMetaAttribute)
-        .serializers(ArticleSerializer)
-        .run()
-    )
+    test_case.settings(
+        {
+            "checks": [
+                {
+                    "id": CheckDRFSerializerMetaAttribute.Id.value,
+                    "attrs": ["read_only_fields"],
+                }
+            ]
+        }
+    ).check(CheckDRFSerializerMetaAttribute)
+
+    messages = test_case.serializers(ArticleSerializer).run()
+    assert not messages
+    messages = test_case.serializers(InheritedArticleSerializer).run()
     assert not messages
     messages = test_case.serializers(AuthorSerializer).run()
     assert len(messages) == 1
     assert messages[0].id == CheckDRFSerializerMetaAttribute.Id.name
+    messages = test_case.serializers(InheritedAuthorSerializer).run()
+    assert len(messages) == 1
+    assert messages[0].id == CheckDRFSerializerMetaAttribute.Id.name
 
 
 def test_get_serializers_to_check():