Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Document Apollo.subscribe() #930

Open
kamilkisiela opened this issue Oct 26, 2018 · 10 comments
Open

[Docs] Document Apollo.subscribe() #930

kamilkisiela opened this issue Oct 26, 2018 · 10 comments
Assignees
Labels
docs Focuses on documentation changes ready
Milestone

Comments

@kamilkisiela
Copy link
Owner

No description provided.

@kamilkisiela kamilkisiela added help wanted good first issue Issues that are suitable for first-time contributors. docs Focuses on documentation changes labels Oct 26, 2018
@theNaut1lus
Copy link

would love to work on this as my first issue here, @kamilkisiela please give me the go ahead for this

@kamilkisiela
Copy link
Owner Author

@co16353sidak 🆗 👍 let me know if you need anything and feel free to contact me :)

@divyanshu-rawat
Copy link

@kamilkisiela Is it open to work on?

@kamilkisiela
Copy link
Owner Author

@divyanshu-rawat yes :) It's there but it's not in the docs

@divyanshu-rawat
Copy link

So, @kamilkisiela can I work on this issue ?

@kamilkisiela
Copy link
Owner Author

of course! Let me know if you need anything from me

@divyanshu-rawat
Copy link

@kamilkisiela , cool then can you assign me this issue :)

@kamilkisiela kamilkisiela added in progress and removed good first issue Issues that are suitable for first-time contributors. help wanted labels Nov 4, 2019
@kamilkisiela kamilkisiela added this to the BEING THE BEST milestone Nov 4, 2019
@kamilkisiela
Copy link
Owner Author

I assigned you, put proper labels and created a milestone :))

@divyanshu-rawat
Copy link

divyanshu-rawat commented Nov 12, 2019

@kamilkisiela do I have to document Apollo.subscribe() here?

https://www.apollographql.com/docs/ios/api/Apollo/extensions/ApolloClient/#methods

By adding this description I guess.

Subscribe to a subscription
Parameters:

subscription: The subscription to subscribe to.
fetchHTTPMethod: The HTTP Method to be used.
queue: A dispatch queue on which the result handler will be called. Defaults to the main queue.
resultHandler: An optional closure that is called when mutation results are available or when an error occurs.
Returns: An object that can be used to cancel an in progress subscription.

@divyanshu-rawat
Copy link

divyanshu-rawat commented Nov 24, 2019

@kamilkisiela could you please give any insights on above comment?

@kamilkisiela kamilkisiela modified the milestones: BEING THE BEST, v3 Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Focuses on documentation changes ready
Projects
None yet
Development

No branches or pull requests

3 participants