hacky solution for #2290

karatelabs · Mar 31, 2023 · 46c4eee · 46c4eee
1 parent acca863
commit 46c4eee
Show file tree

Hide file tree

Showing 6 changed files with 35 additions and 3 deletions.
diff --git a/karate-core/src/main/java/com/intuit/karate/core/ScenarioRuntime.java b/karate-core/src/main/java/com/intuit/karate/core/ScenarioRuntime.java
@@ -92,6 +92,7 @@ public ScenarioRuntime(FeatureRuntime featureRuntime, Scenario scenario) {
         }
         result = new ScenarioResult(scenario);
         if (featureRuntime.setupResult != null) {
+            // TODO improve this and simplify report rendering code in report/karate-feature.html
             StepResult sr = result.addFakeStepResult("@setup", null);
             List<FeatureResult> list = new ArrayList(1);
             FeatureResult fr = new FeatureResult(featureRuntime.featureCall.feature);

diff --git a/karate-core/src/main/java/com/intuit/karate/report/karate-feature.html b/karate-core/src/main/java/com/intuit/karate/report/karate-feature.html
@@ -60,7 +60,7 @@
               <span>ms:</span>&nbsp;<span th:text="Math.round(scenario.durationMillis)"></span>
             </div>
           </div>
-          <div th:if="scenario.stepResults.length > 0 && scenario.stepResults[0].step.background" class="step-row">
+          <div th:if="(scenario.stepResults.length > 0 && scenario.stepResults[0].step.background) || (scenario.stepResults.length > 1 && scenario.stepResults[1].step.background)" class="step-row">
             <div class="step-container" th:id="scenario.refId + 'bg'">
               <div class="step-ref bg-step">&gt;&gt;</div>
               <div class="step-cell passed">Background:</div>

diff --git a/karate-core/src/main/java/com/intuit/karate/report/karate-report.js b/karate-core/src/main/java/com/intuit/karate/report/karate-report.js
@@ -10,7 +10,7 @@ window.onload = function () {
     if (!parentIds[parent.id]) return
     const link = document.createElement('a')
     link.dataset.stepId = parent.id
-    link.href = 'javascript:void()'
+    link.href = 'javascript:void(0)'
     parent.parentNode.insertBefore(link, parent)
     link.appendChild(parent)
   })

diff --git a/karate-core/src/test/java/com/intuit/karate/report/test.feature b/karate-core/src/test/java/com/intuit/karate/report/test.feature
@@ -46,4 +46,14 @@ Examples:
 
 Scenario: calling feature in loop
 * def data = [{ name: 'one' }, { name: 'two' }]
-* call read('called-loop.feature') data
+* call read('called-loop.feature') data
+
+@setup
+Scenario:
+* def data = [{a: 1}, {a: 2}]
+
+Scenario Outline:
+* print __row
+
+Examples:
+| karate.setup().data |
diff --git a/karate-demo/src/test/java/demo/DemoRunner.java b/karate-demo/src/test/java/demo/DemoRunner.java
@@ -32,5 +32,10 @@ void testEncodingParallel() {
         DemoTestParallel.generateReport(results.getReportDir());
         assertTrue(results.getFailCount() == 0, results.getErrorMessages());
     }
+
+    @Karate.Test
+    Karate testOutline() {
+        return Karate.run("classpath:demo/outline/setup-outline.feature");
+    }    
 
 }
diff --git a/karate-demo/src/test/java/demo/outline/setup-outline.feature b/karate-demo/src/test/java/demo/outline/setup-outline.feature
@@ -0,0 +1,16 @@
+Feature:
+
+Background:
+* print 'in background'
+
+@setup
+Scenario:
+* def data = [{a: 1}, {a: 2}]
+
+Scenario Outline:
+* print __row
+
+Examples:
+| karate.setup().data |
+
+