Bump sigs.k8s.io/kind to v0.29.0 #6549
Conversation
karmada-bot
added
the
kind/cleanup
karmada-bot
added
the
size/XXL
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @seanlaii, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on a significant dependency upgrade for sigs.k8s.io/kind, which in turn facilitates updates to the underlying Go and Kubernetes dependencies. It includes a notable refactoring of YAML templating to use standard Go libraries and enhances compatibility with newer containerd configurations. These changes aim to keep the project up-to-date with its core dependencies and improve its robustness.
Highlights
- Dependency Upgrade: The primary change is the upgrade of the
sigs.k8s.io/kinddependency fromv0.25.0tov0.29.0. This update is crucial for aligning with newer Go language versions and Kubernetes dependencies. - Kubernetes Node Image Update: The default
kindest/nodeimage used for Kind clusters has been updated fromv1.31.2tov1.33.1, ensuring compatibility with more recent Kubernetes versions. - YAML Templating Refactor: The custom
github.com/google/safetextmodule, which provided YAML templating with injection prevention, has been removed. Its functionality is now replaced by the standardtext/templatelibrary, and related YAML library imports have been updated tosigs.k8s.io/yaml/goyaml.v3. - Containerd Compatibility: Logic for detecting containerd snapshotters has been enhanced to support both config versions 2 and 3, improving compatibility with various containerd runtime configurations.
- Module Path Renames: The
github.com/alessio/shellescapemodule has been replaced byal.essio.dev/pkg/shellescape, involving file renames and import path adjustments across the codebase.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request bumps the sigs.k8s.io/kind dependency from v0.25.0 to v0.29.0. The changes to go.mod, go.sum, and related vendored files are consistent with this update. The shell scripts for setting up the testing environment have also been updated to use the new kind version.
I have one suggestion to improve maintainability by centralizing the kind_version variable, which is currently duplicated across three shell scripts. This will make future updates easier and less error-prone.
Overall, the changes are straightforward and look good.
hack/setup-dev-base.sh
Outdated
| @@ -60,7 +60,7 @@ util::verify_go_version | |||
| util::cmd_must_exist "docker" | |||
|
|
|||
| # install kind and kubectl | |||
| kind_version=v0.25.0 | |||
| kind_version=v0.29.0 | |||
There was a problem hiding this comment.
The kind_version is hardcoded here and also in hack/cli-testing-environment.sh and hack/cli-testing-init-with-config.sh. To improve maintainability and prevent potential inconsistencies when this version is updated in the future, it would be best to define it in a single, shared location.
A good place for this might be in a central script like hack/util.sh (which is already sourced by these scripts) or a dedicated hack/versions.sh file.
For example, you could define KIND_VERSION="v0.29.0" in a shared script and then use ${KIND_VERSION} in all three places.
There was a problem hiding this comment.
It makes sense to me. @seanlaii What do you think?
There was a problem hiding this comment.
Make sense to me! Updated based on the comment.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6549 +/- ##
=======================================
Coverage 45.45% 45.45%
=======================================
Files 687 687
Lines 56335 56335
=======================================
Hits 25607 25607
Misses 29131 29131
Partials 1597 1597
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Please ignore the failing test, which is tracked by #6547. |
Signed-off-by: wei-chenglai <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bump sigs.k8s.io/kind to v0.29.0 for upgrading golang version and kubernetes dependencies.
Which issue(s) this PR fixes:
Part of #6489
Special notes for your reviewer:
Does this PR introduce a user-facing change?: