Fix the rate-limit issue of kustomize action #6552
Conversation
karmada-bot
added
the
kind/flake
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
karmada-bot
added
the
size/XS
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a rate-limit issue with the kustomize action in the GitHub workflow by switching to a different action implementation that uses authentication to avoid rate limiting.
- Replaces
syntaqx/setup-kustomize@v1withkarancode/[email protected] - Adds GitHub token authentication to prevent API rate limiting
- Updates parameter name from
kustomize-versiontokustomize_version
| @@ -44,9 +44,10 @@ jobs: | |||
| version: ${{ env.HELM_VERSION }} | |||
|
|
|||
| - name: Set up Kustomize | |||
| uses: syntaqx/setup-kustomize@v1 | |||
| uses: karancode/kustomize-github-action@v1.3.2 | |||
There was a problem hiding this comment.
I see there are a lot of bugs reported but not handled:
https://github.com/karancode/kustomize-github-action/issues
I'm not sure if the failing test related to any of these~
There was a problem hiding this comment.
Just found the kustomize installation script itself supports setting token by env. It should be work fine from now.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6552 +/- ##
==========================================
+ Coverage 45.43% 45.45% +0.02%
==========================================
Files 687 687
Lines 56335 56335
==========================================
+ Hits 25596 25609 +13
+ Misses 29140 29130 -10
+ Partials 1599 1596 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iawia002
force-pushed
the
kustomize-action
branch
from
77ec0b2 to
99e279b
Compare
Signed-off-by: Xinzhao Xu <[email protected]>
iawia002
force-pushed
the
kustomize-action
branch
from
99e279b to
e2330eb
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
What type of PR is this?
/kind flake
What this PR does / why we need it:
Fix #6547
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: