Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endre detaljsiden etter skissene #733

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Conversation

malinnsnieske
Copy link
Collaborator

Beskrivelse

🥅 Mål med PRen: 
Forbedre spørsmålssiden etter skissene til Magnus

Løsning

🆕 Endring: 

  • Større overskrift
  • Flytte tags til under overskriften
  • Legge til når det ble sist endret under tags
  • Ha en grå boks til beskrivelsen
  • Knapp for å legge til kommentar
  • Gjøre historikk-farger blå
  • Prøvde å rydde litt i QuestionAnswer koden

image

🧪 Testing

Er det noe spesielt den som reviewer PRen bør sjekke?

🔒 Sikkerhet / Trusselvurdering

  • Er det potensielle risikoer knyttet til endringen?
  • Trengs det noen sikkerhetstiltak eller ytterligere vurderinger?

Resolves #665

@malinnsnieske malinnsnieske linked an issue Mar 27, 2025 that may be closed by this pull request
@malinnsnieske malinnsnieske force-pushed the 665-improve-detailed-view branch from 5ff7b90 to a141311 Compare March 28, 2025 06:58
@@ -43,13 +43,14 @@ export function CheckboxAnswer({
: choices[1]
: ''}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Du vil ikke likesågodt fikse denne til å bruke boolean i stedet mens du er i gang?

<Checkbox colorPalette="blue" checked={value === (choices?.[0] ?? 'checked')} onCheckedChange={(e) => { const newValue = e.checked ? (choices?.[0] ?? 'checked') : (choices?.[1] ?? 'unchecked'); setAnswerInput(newValue); submitAnswer(newValue); }} size="md" disabled={disabled} > {choices?.length === 2 && value ? value === (choices?.[0] ?? 'checked') ? choices[0] : choices[1] : ''}

@malinnsnieske malinnsnieske merged commit b45ebdf into main Mar 31, 2025
16 checks passed
@malinnsnieske malinnsnieske deleted the 665-improve-detailed-view branch March 31, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forbedre detaljsiden for hvert element i skjemaet
3 participants