From 6c0a1172587f7e64e3827ab5395d78ae156e2853 Mon Sep 17 00:00:00 2001
From: Antonio myracho <26426455+myrachanto@users.noreply.github.com>
Date: Sat, 24 Aug 2024 12:52:39 +0300
Subject: [PATCH 1/2] Resource Name Shortener shortens the resource name if it
 exceeds maxResourceNameLength

---
 pkg/block/block_mount.go |  4 ++--
 pkg/block/helper.go      | 28 ++++++++++++++++++++++++++++
 pkg/block/helper_test.go | 39 +++++++++++++++++++++++++++++++++++++++
 3 files changed, 69 insertions(+), 2 deletions(-)
 create mode 100644 pkg/block/helper.go
 create mode 100644 pkg/block/helper_test.go

diff --git a/pkg/block/block_mount.go b/pkg/block/block_mount.go
index e4c2070..e032d8a 100644
--- a/pkg/block/block_mount.go
+++ b/pkg/block/block_mount.go
@@ -76,8 +76,8 @@ func NewBlockMountChecker(args BlockMountCheckerArgs) (BlockMountChecker, error)
 
 	b := &blockMountChecker{}
 	b.args = args
-	b.podName = fmt.Sprintf(blockMountCheckerPodNameFmt, b.args.StorageClass)
-	b.pvcName = fmt.Sprintf(blockMountCheckerPVCNameFmt, b.args.StorageClass)
+	b.podName = ResourceNameShortener(fmt.Sprintf(blockMountCheckerPodNameFmt, b.args.StorageClass))
+	b.pvcName = ResourceNameShortener(fmt.Sprintf(blockMountCheckerPVCNameFmt, b.args.StorageClass))
 	b.validator = csi.NewArgumentValidator(b.args.KubeCli, b.args.DynCli)
 	b.appCreator = csi.NewApplicationCreator(b.args.KubeCli, args.K8sObjectReadyTimeout)
 	b.cleaner = csi.NewCleaner(b.args.KubeCli, b.args.DynCli)
diff --git a/pkg/block/helper.go b/pkg/block/helper.go
new file mode 100644
index 0000000..a6c963f
--- /dev/null
+++ b/pkg/block/helper.go
@@ -0,0 +1,28 @@
+package block
+
+import (
+	"crypto/sha256"
+	"encoding/base64"
+)
+
+// resource name maxs lenght
+const maxResourceNameLength = 64
+
+// ResourceNameShortener shortens the resource name if it exceeds maxResourceNameLength.
+// It replaces the last 5 characters with the first 5 characters of a hash (base64 encoded).
+func ResourceNameShortener(name string) string {
+	if len(name) <= maxResourceNameLength {
+		return name
+	}
+
+	// Create a SHA-256 hash of the name
+	hash := sha256.Sum256([]byte(name))
+
+	// Convert the hash to a base64 string
+	hashBase64 := base64.RawURLEncoding.EncodeToString(hash[:])
+
+	// Truncate the name and replace the last 5 characters with the first 5 characters of the hash
+	truncatedName := name[:maxResourceNameLength-6] + "-" + hashBase64[:5]
+
+	return truncatedName
+}
diff --git a/pkg/block/helper_test.go b/pkg/block/helper_test.go
new file mode 100644
index 0000000..df3f8b7
--- /dev/null
+++ b/pkg/block/helper_test.go
@@ -0,0 +1,39 @@
+package block
+
+import (
+	"testing"
+)
+
+// TestShortenResourceName tests different variations of the ephemeral resource name.
+func TestResourceNameShortener(t *testing.T) {
+	tests := []struct {
+		name     string
+		input    string
+		expected int // We will check the length of the output
+	}{
+		{
+			name:     "Short name (less than 64 characters)",
+			input:    "ephemeral-persistent-volume-claim",
+			expected: len("ephemeral-persistent-volume-claim"),
+		},
+		{
+			name:     "Exact 64 characters",
+			input:    "ephemeral-persistent-volume-claim-for-application-persistent-volume-clai",
+			expected: 64,
+		},
+		{
+			name:     "Name longer than 64 characters",
+			input:    "ephemeral-persistent-volume-claim-for-application-persistent-volume-claim",
+			expected: 64,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := ResourceNameShortener(tt.input)
+			if len(got) != tt.expected {
+				t.Errorf("ShortenResourceName() = %v (length %d), expected length %d", got, len(got), tt.expected)
+			}
+		})
+	}
+}

From 5c7fc4dcde7fd5b76cde1d4fc25e5cb3d3dd87bd Mon Sep 17 00:00:00 2001
From: Antonio myracho <26426455+myrachanto@users.noreply.github.com>
Date: Sat, 24 Aug 2024 12:58:03 +0300
Subject: [PATCH 2/2] fixed #295 ResourceNameShortener shortens the resource
 name if it exceeds maxResourceNameLength of 64

---
 pkg/block/helper.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pkg/block/helper.go b/pkg/block/helper.go
index a6c963f..51e2727 100644
--- a/pkg/block/helper.go
+++ b/pkg/block/helper.go
@@ -8,7 +8,7 @@ import (
 // resource name maxs lenght
 const maxResourceNameLength = 64
 
-// ResourceNameShortener shortens the resource name if it exceeds maxResourceNameLength.
+// ResourceNameShortener shortens the resource name if it exceeds maxResourceNameLength of 64.
 // It replaces the last 5 characters with the first 5 characters of a hash (base64 encoded).
 func ResourceNameShortener(name string) string {
 	if len(name) <= maxResourceNameLength {