Skip to content

Commit 9fb2af9

Browse files
committed
Fix Webpack 4 DefinePlugin config
1 parent 4767814 commit 9fb2af9

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## Draft
44
- Fix wishlist dropdown background color bleeding out of container [#1283](https://github.com/bigcommerce/cornerstone/pull/1283)
55
- Fix indefinite load spinner for products without an image in order history. [#1284](https://github.com/bigcommerce/cornerstone/pull/1284)
6+
- Fix Webpack DefinePlugin configuration. [#1286](https://github.com/bigcommerce/cornerstone/pull/1286)
67

78
## 2.2.0 (2018-06-22)
89
- Fix quantity edit on Simple Product AMP pages. [#1257](https://github.com/bigcommerce/cornerstone/pull/1257)

webpack.dev.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ module.exports = merge(commonConfig, {
77
devtool: 'source-map',
88
plugins: [
99
new webpack.DefinePlugin({
10-
'process.env.NODE_ENV': 'development',
10+
'process.env.NODE_ENV': JSON.stringify('development'),
1111
}),
1212
],
1313
});

webpack.prod.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module.exports = merge(commonConfig, {
66
mode: 'production',
77
plugins: [
88
new webpack.DefinePlugin({
9-
'process.env.NODE_ENV': 'production',
9+
'process.env.NODE_ENV': JSON.stringify('production'),
1010
}),
1111
],
1212
});

0 commit comments

Comments
 (0)