Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake clientset methods doesn't work properly #33

Open
ShreyanshMehta opened this issue Oct 23, 2023 · 0 comments
Open

Fake clientset methods doesn't work properly #33

ShreyanshMehta opened this issue Oct 23, 2023 · 0 comments

Comments

@ShreyanshMehta
Copy link

ShreyanshMehta commented Oct 23, 2023

Methods like List() and UpdateStatus() from fake clientset doesn't work properly. As Create() method from fake clientset does not add kcp.io/cluster annotation to the object (which is expected) which is later being used by List() and UpdateStatus() to filter the objects.

Ideally, these method shouldn't depend on the annotation to filter the objects.
For example, List() uses the filterByCluster() to filter the object which internally uses the given annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant