fix(notifications): address PR #2528 review comments

- Fix manifest ID not updated after notification create/update:
  Set notificationState.NotificationManifest.ID = created.ID in the
  WithOnSuccess callback so the manifest correctly persists the
  API-assigned subscription ID after push.

- Write auto-filters back to local files after push:
  Update notification.Filters = created.Filters in callback so the
  API-assigned filters (including auto-populated branch.id,
  job.component.id, job.configuration.id) are written back to
  config.json after push via a local save in remote.UnitOfWork.Invoke().

- Remove unnecessary custom JSON marshaling from ConfigManifestWithRows:
  Add MarshalJSON to NotificationManifest that outputs only {id, path},
  removing the need for NotificationManifestRef wrapper struct and the
  custom ConfigManifestWithRows.MarshalJSON method.

- Remove docs/notifications.md as requested by reviewer.

- Remove notification-specific subsections from CLI_OBJECT_LIFECYCLE.md
  (Auto-Filter Behavior and Delete-Then-Create for Updates sections).

- Fix E2E test manifests to use %A wildcard for API-assigned IDs.

- Update E2E test out config.json files to include auto-filters.

- Add new E2E test notifications-create-with-filters to verify that
  user-specified filters are combined with auto-populated filters.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: Matovidlo

docs/CLI_OBJECT_LIFECYCLE.md

@@ -350,39 +350,6 @@ u.changes.AddCreated(notificationState)
 // IDs in manifest.json are updated for new notifications via manifest.Save()
 ```
 
-### Auto-Filter Behavior
-
-Users write only `event` + `recipient` (and optionally custom `filters`) in `config.json`. During push, three standard filters are **auto-populated** by `createNotificationRequest()`:
-
-- `branch.id` — from the notification's `BranchID`
-- `job.component.id` — from the notification's `ComponentID`
-- `job.configuration.id` — from the notification's `ConfigID`
-
-These filters are required by the API to scope the notification to a specific config. They are appended before any user-defined filters.
-
-The API returns all filters (auto + user) in the response, so after a `pull`, `config.json` contains all three auto-filters plus any user-defined ones.
-
-**Consequence:** On a repeated `push` without `pull`:
-- Local `config.json` has no auto-filters (they were never written locally)
-- Remote notification has all three auto-filters
-- Diff engine shows `changed: filters`
-- This is **expected behavior**, not a bug
-
-### Delete-Then-Create for Updates
-
-The notifications API has no update endpoint. Changes are implemented as:
-1. Delete the old notification subscription
-2. Create a new one with the changed values
-
-This is implemented via `WithOnSuccess` callback chaining in `UnitOfWork.SaveObject`:
-```go
-// Pseudocode in remote/manager.go
-deleteReq.WithOnSuccess(func(...) {
-    // On successful delete, create the new one
-    return createReq.Send(ctx)
-})
-```
-
 ---
 
 ## Common Pitfalls

internal/pkg/model/manifest.go

@@ -1,11 +1,9 @@
 package model
 
 import (
-	"encoding/json"
 	"fmt"
 
 	"github.com/keboola/go-utils/pkg/orderedmap"
-	"github.com/keboola/keboola-sdk-go/v2/pkg/keboola"
 
 	"github.com/keboola/keboola-as-code/internal/pkg/filesystem"
 	"github.com/keboola/keboola-as-code/internal/pkg/utils/errors"
@@ -91,44 +89,11 @@ type ConfigRowManifest struct {
 	Relations Relations `json:"relations,omitempty" validate:"dive"` // relations with other objects, for example variables values definition
 }
 
-type NotificationManifestRef struct {
-	ID   keboola.NotificationSubscriptionID `json:"id"`
-	Path string                             `json:"path,omitempty"`
-}
-
 type ConfigManifestWithRows struct {
 	ConfigManifest
 	Rows []*ConfigRowManifest `json:"rows"`
 }
 
-// MarshalJSON implements custom JSON marshaling to simplify notifications to just IDs.
-func (c *ConfigManifestWithRows) MarshalJSON() ([]byte, error) {
-	// Convert notifications to simplified refs
-	notificationRefs := make([]*NotificationManifestRef, 0, len(c.Notifications))
-	for _, n := range c.Notifications {
-		if n != nil {
-			notificationRefs = append(notificationRefs, &NotificationManifestRef{ID: n.ID, Path: n.GetRelativePath()})
-		}
-	}
-
-	// Create a copy with simplified notifications
-	return json.Marshal(&struct {
-		ConfigKey
-		Paths
-		Relations     Relations                  `json:"relations,omitempty"`
-		Metadata      *orderedmap.OrderedMap     `json:"metadata,omitempty"`
-		Rows          []*ConfigRowManifest       `json:"rows"`
-		Notifications []*NotificationManifestRef `json:"notifications,omitempty"`
-	}{
-		ConfigKey:     c.ConfigKey,
-		Paths:         c.Paths,
-		Relations:     c.Relations,
-		Metadata:      c.Metadata,
-		Rows:          c.Rows,
-		Notifications: notificationRefs,
-	})
-}
-
 func (p *Paths) ClearRelatedPaths() {
 	p.RelatedPaths = make([]string, 0)
 }

internal/pkg/model/notificationmanifest.go

@@ -1,7 +1,10 @@
 package model
 
 import (
+	"encoding/json"
 	"fmt"
+
+	"github.com/keboola/keboola-sdk-go/v2/pkg/keboola"
 )
 
 // NotificationManifest represents a notification manifest record.
@@ -12,6 +15,18 @@ type NotificationManifest struct {
 	Relations Relations `json:"relations,omitempty" validate:"dive"`
 }
 
+// MarshalJSON serializes only the ID and path, omitting the embedded NotificationKey fields
+// (branchId, componentId, configId) which would otherwise appear in the manifest JSON.
+func (n *NotificationManifest) MarshalJSON() ([]byte, error) {
+	return json.Marshal(&struct {
+		ID   keboola.NotificationSubscriptionID `json:"id"`
+		Path string                             `json:"path,omitempty"`
+	}{
+		ID:   n.ID,
+		Path: n.GetRelativePath(),
+	})
+}
+
 // NewEmptyObject creates an empty Notification object with the key from this manifest.
 func (n NotificationManifest) NewEmptyObject() Object {
 	return &Notification{NotificationKey: n.NotificationKey}

internal/pkg/service/cli/CLI_CONTEXT.md

@@ -18,7 +18,6 @@ The CLI supports managing notification subscriptions for configurations. Notific
 - `push`: Create/delete notifications (no update API - delete + create)
 - Manifest tracks subscription IDs for sync
 
-See [docs/notifications.md](docs/notifications.md) for detailed documentation.
 
 ## Overview