Ai 1186 simplify config models #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radcliffkey
reviewed
Jul 8, 2025
ncapek
commented
Jul 9, 2025
|
@mariankrotil Please pay special attention to reviewing changes that may be relevant to the |
ncapek
commented
Jul 9, 2025
Seems ok to me. What exact error have you been getting? |
radcliffkey
reviewed
Jul 14, 2025
vita-stejskal
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component tools System Refactoring
This PR introduces a major architectural change to the Keboola MCP server's component management system, focusing on cleaner model design, cleaner separation of concerns, and improved maintainability.
Key Changes
Model Architecture Overhaul
Replaced
ComponentConfigurationMetadatawith structured models:ConfigurationSummarycontainingConfigurationRootSummary+ConfigurationRowSummary.Introduced factory method pattern (
Component.from_api_response()) replacing directmodel_validate()callsAdded computed
ComponentCapabilitiesderived from API flags field, providing cleaner access tois_row_based,has_ui, etc.Completely removed inheritance in pydantic models for easier navigation
API Response Consistency
Established cleaner data flow: Raw API → APIComponentResponse → Component/Configuration domain models
Separated API models (
api_models.py) from business domain models (model.py)Code Organization
Added comprehensive module documentation explaining model usage patterns
Organized code into logical sections with clear headers and improved docstrings
Legacy models
Maintained legacy models as some of them are still used in Flow tools