Skip to content

Fix generic types issue in the upgrades functions #48

@jagodarybacka

Description

@jagodarybacka
Collaborator

Reference #46 (comment)

There is a problem with using typechain's contract interfaces like upgradeProxy<ContractTypeFromTypechain>() - the types don't match because typechain is creating types based on the ethers' BaseContract type but OpenZeppelin's upgradeProxy and deployProxy are returning ethers' Contract type - these are not interchangeable.

OpenZeppelin/openzeppelin-upgrades#535 would probably fix this issue but is not merged yet

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @jagodarybacka

        Issue actions

          Fix generic types issue in the upgrades functions · Issue #48 · keep-network/hardhat-helpers