update #131: Rename feature to dashmap and change implementation.

Author: mrtryhard

i18n-embed-fl/Cargo.toml

@@ -34,5 +34,5 @@ pretty_assertions = { workspace = true }
 rust-embed = { workspace = true }
 
 [features]
-# Enables more performant version of the crate. May download extra dependencies.
-performance = ["dep:dashmap"]
+# Uses dashmap implementation for `fl!()` macro lookups.
+dashmap = ["dep:dashmap"]

i18n-embed-fl/src/lib.rs

@@ -10,12 +10,11 @@ use std::{
     sync::OnceLock,
 };
 
-#[cfg(not(feature = "performance"))]
+#[cfg(feature = "dashmap")]
+use dashmap::mapref::one::Ref;
+#[cfg(not(feature = "dashmap"))]
 use std::sync::{Arc, RwLock};
 
-#[cfg(feature = "performance")]
-use dashmap::{mapref::one::Ref, DashMap, Entry};
-
 use syn::{parse::Parse, parse_macro_input, spanned::Spanned};
 use unic_langid::LanguageIdentifier;
 
@@ -174,23 +173,37 @@ struct DomainSpecificData {
 
 #[derive(Default)]
 struct DomainsMap {
-    #[cfg(not(feature = "performance"))]
+    #[cfg(not(feature = "dashmap"))]
     map: RwLock<HashMap<String, Arc<DomainSpecificData>>>,
 
-    #[cfg(feature = "performance")]
+    #[cfg(feature = "dashmap")]
     map: dashmap::DashMap<String, DomainSpecificData>,
 }
 
+#[cfg(feature = "dashmap")]
+impl DomainsMap {
+    fn get(&self, domain: &String) -> Option<Ref<String, DomainSpecificData>> {
+        self.map.get(domain)
+    }
+
+    fn entry_or_insert(
+        &self,
+        domain: &String,
+        data: DomainSpecificData,
+    ) -> Ref<String, DomainSpecificData> {
+        self.map.entry(domain.clone()).or_insert(data).downgrade()
+    }
+}
+
+#[cfg(not(feature = "dashmap"))]
 impl DomainsMap {
-    #[cfg(not(feature = "performance"))]
     fn get(&self, domain: &String) -> Option<Arc<DomainSpecificData>> {
         match self.map.read().unwrap().get(domain) {
             None => None,
             Some(data) => Some(data.clone()),
         }
     }
 
-    #[cfg(not(feature = "performance"))]
     fn entry_or_insert(
         &self,
         domain: &String,
@@ -203,20 +216,6 @@ impl DomainsMap {
             .or_insert(Arc::new(data))
             .clone()
     }
-
-    #[cfg(feature = "performance")]
-    fn get(&self, domain: &String) -> Option<Ref<String, DomainSpecificData>> {
-        self.map.get(domain)
-    }
-
-    #[cfg(feature = "performance")]
-    fn entry_or_insert(
-        &self,
-        domain: &String,
-        data: DomainSpecificData,
-    ) -> Ref<String, DomainSpecificData> {
-        self.map.entry(domain.clone()).or_insert(data).downgrade()
-    }
 }
 
 fn domains() -> &'static DomainsMap {