Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepping Stones: Issue with PDF deep linking on macOS #478

Open
halibeanz opened this issue Jul 6, 2024 · 2 comments
Open

Stepping Stones: Issue with PDF deep linking on macOS #478

halibeanz opened this issue Jul 6, 2024 · 2 comments
Assignees

Comments

@halibeanz
Copy link

Bug description
When clicking on an Action in the Stepping Stones Flow, the last page of the PDF document is what is highlighted instead of the mentioned action.

Upon further research, the link does not resemble what it would look like if it was accessed via Firefox (which is where it currently operates correctly). This issue has come up on both Safari and Google Chrome.

Stepping Stones Bug Stepping Stones link error Stepping Stones action error 2

Reproduction steps

  1. Go to Kendraio App
  2. Click on Flow Cloud
  3. Search for Stepping Stones
  4. Launch Stepping Stones
  5. Scroll down to fourth row
  6. Click on Action 18
  7. See error

Expected behaviour
When clicking on the Action number, it should redirect you to the PDF and highlight that specific Action within the document.

Flow Configuration

Runtime environment

  • OS: Ventura 13.6.7
  • Browser: Safari 17.5, Google Chrome 126.0.6478.127
  • App version: 0.5.0
  • Angular Version: 15.2.1
@halibeanz halibeanz changed the title Stepping Stones: Issue with PDF deep linking on Mac OS Stepping Stones: Issue with PDF deep linking on macOS Jul 9, 2024
@lukestanley lukestanley self-assigned this Jul 9, 2024
@lukestanley
Copy link
Member

lukestanley commented Jul 16, 2024

The cause is that WebKit (used by Safari) supports fragments and provides an empty location hash when it finds one, as per the specification.
I am working on a fix that avoids depending on the location hash part.

@lukestanley
Copy link
Member

A fix has been made that uses the "search" query parameter instead.
https://kendraio.github.io/kendraio-gists/pdf_deep_link.htm?site=https://documents.un.org/api/symbol/access?j=N1039021&t=pdf&search=Action%2018%3A
Does this link work on Safari and Google Chrome for you?
@halibeanz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants