diff-so-fancy: just install the file instead of using NPM

Author: kenyon

Puppetfile

@@ -12,7 +12,6 @@ mod 'puppet-hiera',
 mod 'puppet-kmod', :latest
 mod 'puppet-letsencrypt', :latest
 mod 'puppet-logrotate', :latest
-mod 'puppet-nodejs', :latest
 mod 'puppet-postfix', :latest
 mod 'puppet-python', :latest
 mod 'puppet-r10k', :latest

data/common.yaml

@@ -67,6 +67,14 @@ packages_absent:
   - rdnssd
   - resolvconf
 
+files:
+  /usr/local/bin/diff-so-fancy:
+    ensure: file
+    mode: '0755'
+    owner: root
+    group: root
+    source: https://github.com/so-fancy/diff-so-fancy/releases/download/v1.4.4/diff-so-fancy
+
 apache::default_ssl_vhost: false
 apache::default_vhost: false
 apache::mod::ssl::reload_on_change: true
@@ -197,10 +205,6 @@ munin::node::plugins:
     checksum: sha256
     checksum_value: 5794598a673f181dd5033fc90f33f0e059c501152455ee5b190a4cc7b2a4cdd3
 
-nodejs::manage_package_repo: false
-nodejs::manage_nodejs_package: false
-nodejs::npm_package_ensure: present
-
 postfix::inet_interfaces: loopback-only
 # https://github.com/voxpupuli/puppet-postfix/pull/256
 postfix::mydestination: $myhostname, localhost.$mydomain, localhost

data/kernel/Linux.yaml

@@ -24,9 +24,6 @@ packages:
   - ndisc6
   - time
 
-npm_packages:
-  - diff-so-fancy
-
 ini_settings:
   systemd disable CtrlAltDelBurstAction:
     path: /etc/systemd/system.conf

manifests/main.pp

@@ -27,14 +27,6 @@
   }
 }
 
-lookup('npm_packages', Array[String], 'unique', []).each |String $pkg| {
-  package { "npm_${pkg}":
-    ensure   => present,
-    provider => 'npm',
-    name     => $pkg,
-  }
-}
-
 lookup('services', Hash, 'hash', {}).each |$key, $value| {
   service { $key:
     * => $value,