Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylint score is too low #761

Open
cawibo opened this issue Mar 4, 2021 · 5 comments
Open

pylint score is too low #761

cawibo opened this issue Mar 4, 2021 · 5 comments

Comments

@cawibo
Copy link
Contributor

cawibo commented Mar 4, 2021

The pylint score for this project is terribly low at 6.57. Many of the issues are non-issues for a project such as this, eg. broken naming conventions because of typical algorithm variable naming. However, there are still a ton of issues that should be dealt with, including but not limited to trailing whitespace, missing docstrings, dead code (after return), uncaught strings, and out-dated iteration using range with len.

Many of these issues could be taken care of automatically. I propose that we start with that.

@keon
Copy link
Owner

keon commented Mar 10, 2021

sounds good!
I wanted to clean the repo up so bad, but didn't have time :(.
Would be awesome if we could get contribution.

@nitish771
Copy link

Sure

sounds good!
I wanted to clean the repo up so bad, but didn't have time :(.
Would be awesome if we could get contribution.

Ready to contribute :)

@ericklarac
Copy link
Collaborator

@cawibo are you still interested working on this?

@hariharanragothaman
Copy link

@ericklarac @keon I can work on this! Can I pick this up?

@keon
Copy link
Owner

keon commented Dec 14, 2021

Yes :) feel free to take any tasks you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants