Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Make config parsing stricter #16

Open
botchk opened this issue Jun 14, 2021 · 0 comments
Open

Make config parsing stricter #16

botchk opened this issue Jun 14, 2021 · 0 comments
Labels
type:feature New feature or request that provides value to the stakeholders/end-users

Comments

@botchk
Copy link
Collaborator

botchk commented Jun 14, 2021

Currently we do not enforce a lot or rules during the config parsing, just for an example the following configuration is valid and works:

apiVersion: v1
actions:
  - events:
      - name: "sh.keptn.event.echo.triggered"
    tasks:
      - image: "bash"
        cmd: "echo hello"

With multiple configurations like that we would run into trouble since we do lookups of the actions by names. I think it would help if we require at least:

  • name of the action
  • name of the task

and give feedback on the bridge if config is not valid (currently it is only logged in the pod)

@botchk botchk added type:feature New feature or request that provides value to the stakeholders/end-users ready-for-refinement Issue is relevant for the next backlog refinment labels Jun 14, 2021
@thisthat thisthat removed the ready-for-refinement Issue is relevant for the next backlog refinment label Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:feature New feature or request that provides value to the stakeholders/end-users
Projects
None yet
Development

No branches or pull requests

2 participants