Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Ability to specify annotations to jobs #278

Open
braghettos opened this issue Jun 16, 2022 · 5 comments
Open

Ability to specify annotations to jobs #278

braghettos opened this issue Jun 16, 2022 · 5 comments
Labels
type:feature New feature or request that provides value to the stakeholders/end-users

Comments

@braghettos
Copy link

Hi everyone! My use case is the following: I need to use the job-executor-service to connect to an application server in order to deploy a .war but credentials need to be fetched from a Vault. It would be great if I could set some annotations that could let Vault to inject a sidecar for secrets management.

@christian-kreuzberger-dtx
Copy link
Contributor

Thanks @braghettos for your request.

If we think about a more general user story, the request would also be "Pass secrets from Vault to Job-Executor", where the annotation part is then just a technical detail (among others).

I guess there would then be a side-car that provides secrets? https://learn.hashicorp.com/tutorials/vault/kubernetes-sidecar

@christian-kreuzberger-dtx christian-kreuzberger-dtx added the type:feature New feature or request that provides value to the stakeholders/end-users label Jun 17, 2022
@braghettos
Copy link
Author

@christian-kreuzberger-dtx
Copy link
Contributor

@braghettos
Copy link
Author

@christian-kreuzberger-dtx that's great! Giving a look at the code looks promising.

@christian-kreuzberger-dtx
Copy link
Contributor

Hey @braghettos , any feedback if this is working as intended?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:feature New feature or request that provides value to the stakeholders/end-users
Projects
None yet
Development

No branches or pull requests

2 participants