Detections are identified as generic "Motion" rather than "Person"/"Vehicle" in unifi-protect

[zzzbatmand]

Intro

I have made a few discoveries these past couple of days, and have decided to share them with the community.
I will be splitting them up in different discussions, please tell me if I should merge them.

Problem

There are currently some issues with unifi-protect v4 and u-c-p #372 so I use v3.0.26 instead.
But apparently events in v3.0.26 show up as generic "Motion" instead of what actually is sent from u-c-p.
I have tested with older versions and found that even back to v2.11.21 also has this issue.

I have these few days read through a lot of logs, as well as the source code for unifi-protect and have found the issue.
It appears that the "objectTypes" is never read by unifi-protect.

This is the detection event in both v2 and v3 of unifi-protect:

const p = {
  type: o,
  cameraId: i.pk,
  start: l,
  smartDetectTypes: [], // <--- This is the issue.
  score: T(u),
  metadata: {}
};

As show "smartDetectTypes" is ALWAYS an empty array, and therefore never updated correctly.

Solution

This can be fixed, by manually patching the unifi-protect source at "/usr/share/unifi-protect/app/service.js"
The file is minified so a steady hand is needed for this.
Find the following code:

verbose("smart.detect.event.start",i.logId,n);const l=h(i,n,f.START),u=o===d.SMART_DETECT_ZONE?n.zonesStatus:n.linesStatus;if(i.recordingMode===v.NEVER)return void y.verbose(`${i.logId} current recording mode is "never", skip to save this smartDetect event`);i.updateAndSave({isSmartDetected:!0});const p={type:o,cameraId:i.pk,start:l,smartDetectTypes:[]

And replace it with the following:

verbose("smart.detect.event.start",i.logId,n);const l=h(i,n,f.START),u=o===d.SMART_DETECT_ZONE?n.zonesStatus:n.linesStatus;const detectTypes=Array.isArray(n.objectTypes)?n.objectTypes:[];if(i.recordingMode===v.NEVER)return void y.verbose(`${i.logId} current recording mode is "never", skip to save this smartDetect event`);i.updateAndSave({isSmartDetected:!0});const p={type:o,cameraId:i.pk,start:l,smartDetectTypes:detectTypes

Save and close the file, then restart the unifi-protect from the web interface. (Just stop and start unifi-protect)

[zzzbatmand]

This solution also works for uifi-protect v4.0.33, but the code has changed so the following needs to be updated.

Find this code:

if(i.recordingMode===d.RECORDING_MODES.NEVER)return void v.verbose(`${i.logId} current recording mode is "never", skip to save this smartDetect event`);i.updateAndSave({isSmartDetected:!0});const S={type:o,cameraId:i.pk,start:g,smartDetectTypes:[]

And replace it with this: (Only the start and end is changed)

const detectTypes=Array.isArray(s.objectTypes)?s.objectTypes:[];if(i.recordingMode===d.RECORDING_MODES.NEVER)return void v.verbose(`${i.logId} current recording mode is "never", skip to save this smartDetect event`);i.updateAndSave({isSmartDetected:!0});const S={type:o,cameraId:i.pk,start:g,smartDetectTypes:detectTypes