Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Dashboard filters (e.g. namespace prefix) are not applied any more #7091

Closed
loicmathieu opened this issue Jan 30, 2025 · 5 comments · Fixed by #7935
Closed

Custom Dashboard filters (e.g. namespace prefix) are not applied any more #7091

loicmathieu opened this issue Jan 30, 2025 · 5 comments · Fixed by #7935
Assignees
Labels
area/backend Needs backend code changes area/frontend Needs frontend code changes bug Something isn't working

Comments

@loicmathieu
Copy link
Member

Describe the issue

Reproducible on both JDBC and Elastic.
Using the 'Overview' custom dashboard that is proposed when you create a new custom dashboard.

When filtering on label, using 'start with' and the company.team namespace, you have some results

Image

When doing the same but with the company label you didn't have any results.

Image

Environment

  • Kestra Version: develop
@loicmathieu loicmathieu added area/backend Needs backend code changes area/frontend Needs frontend code changes bug Something isn't working labels Jan 30, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Issues Jan 30, 2025
@MilosPaunovic MilosPaunovic moved this from Backlog to In review in Issues Feb 19, 2025
@MilosPaunovic
Copy link
Member

I would say that this now could safely be closed due to recent changes on filtering, could you double check it @anna-geller?

@anna-geller
Copy link
Member

the filter seems to have no effect in both the default and custom dashboards so the issue is still here https://capture.dropbox.com/JQ8gyjvdumbtZrrf

@MilosPaunovic MilosPaunovic moved this from In review to Backlog in Issues Feb 19, 2025
@anna-geller anna-geller moved this from Backlog to In progress in Issues Feb 19, 2025
@MilosPaunovic MilosPaunovic moved this from In progress to Backlog in Issues Mar 3, 2025
@MilosPaunovic
Copy link
Member

I'd say that this is (now) much bigger problem than the title of this issue states.

None of the filters on any of the dashboards (default nor custom) seem to work.

What I can do on the UI side is to make it work with previous filters, meaning we won't have any exclusive ones (IS NOT, NOT IN) nor we'll have the filtering of multiple namespaces at once.

I'd say that that's not what we want here @Ben8t, but we'd need to amend the dashboard endpoints on the BE side to include new filtering system. Correct me if I'm wrong @Skraye/@brian-mulier-p.

@anna-geller anna-geller changed the title Custom Dashboard filter namespace 'start with' didn't work with namespace prefix Custom Dashboard filters (e.g. namespace prefix) are not applied any more Mar 3, 2025
@MilosPaunovic MilosPaunovic moved this from Backlog to In progress in Issues Mar 5, 2025
@Skraye Skraye moved this from In progress to Backlog in Issues Mar 6, 2025
@MilosPaunovic
Copy link
Member

@Skraye When you get to this, maybe take this PR into account also, as it seems related a bit #6922.

@anna-geller
Copy link
Member

Yann is on it, filters atm BE and FE are not compatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend Needs backend code changes area/frontend Needs frontend code changes bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants