File tree Expand file tree Collapse file tree 1 file changed +6
-1
lines changed
plugins/Kaleidoscope-Colormap-Overlay/src/kaleidoscope/plugin Expand file tree Collapse file tree 1 file changed +6
-1
lines changed Original file line number Diff line number Diff line change @@ -38,7 +38,12 @@ namespace plugin {
3838uint16_t ColormapOverlay::map_base_;
3939
4040void ColormapOverlay::setup () {
41- // TODO: check if a call to ::LEDPaletteTheme.reserveThemes() is actually needed
41+ // It appears that a call to ::LEDPaletteTheme.reserveThemes() is needed
42+ // because it's where palette_base_ gets initialized. Since this plugin (and
43+ // possibly others) don't actually use themes, requesting memory for storing
44+ // themes doesn't make much sense. Maybe initialisation of palette_base_
45+ // could be moved to a setup() method, though maybe the palette should be
46+ // split from palette theme altogether?
4247 map_base_ = ::LEDPaletteTheme.reserveThemes (1 );
4348}
4449
You can’t perform that action at this time.
0 commit comments