Skip to content

Commit 22d8790

Browse files
committed
Update TODO with preliminary findings
Signed-off-by: Evy Bongers <[email protected]>
1 parent ea611d0 commit 22d8790

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

plugins/Kaleidoscope-Colormap-Overlay/src/kaleidoscope/plugin/Colormap-Overlay.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,12 @@ namespace plugin {
3838
uint16_t ColormapOverlay::map_base_;
3939

4040
void ColormapOverlay::setup() {
41-
// TODO: check if a call to ::LEDPaletteTheme.reserveThemes() is actually needed
41+
// It appears that a call to ::LEDPaletteTheme.reserveThemes() is needed
42+
// because it's where palette_base_ gets initialized. Since this plugin (and
43+
// possibly others) don't actually use themes, requesting memory for storing
44+
// themes doesn't make much sense. Maybe initialisation of palette_base_
45+
// could be moved to a setup() method, though maybe the palette should be
46+
// split from palette theme altogether?
4247
map_base_ = ::LEDPaletteTheme.reserveThemes(1);
4348
}
4449

0 commit comments

Comments
 (0)