Skip to content

Commit 5113820

Browse files
committed
Update TODO with preliminary findings
Signed-off-by: Evy Bongers <[email protected]>
1 parent ea611d0 commit 5113820

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

plugins/Kaleidoscope-Colormap-Overlay/src/kaleidoscope/plugin/Colormap-Overlay.cpp

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,13 @@ namespace plugin {
3838
uint16_t ColormapOverlay::map_base_;
3939

4040
void ColormapOverlay::setup() {
41-
// TODO: check if a call to ::LEDPaletteTheme.reserveThemes() is actually needed
41+
// TODO(EvyBongers): it appears that a call to
42+
// ::LEDPaletteTheme.reserveThemes() is needed because it's where
43+
// palette_base_ gets initialized. Since this plugin (and possibly others)
44+
// don't actually use themes, requesting memory for storing themes doesn't
45+
// make much sense. Maybe initialisation of palette_base_ could be moved to a
46+
// setup() method, though maybe the palette should be split from palette
47+
// theme altogether?
4248
map_base_ = ::LEDPaletteTheme.reserveThemes(1);
4349
}
4450

0 commit comments

Comments
 (0)