File tree Expand file tree Collapse file tree 1 file changed +7
-1
lines changed
plugins/Kaleidoscope-Colormap-Overlay/src/kaleidoscope/plugin Expand file tree Collapse file tree 1 file changed +7
-1
lines changed Original file line number Diff line number Diff line change @@ -38,7 +38,13 @@ namespace plugin {
3838uint16_t ColormapOverlay::map_base_;
3939
4040void ColormapOverlay::setup () {
41- // TODO: check if a call to ::LEDPaletteTheme.reserveThemes() is actually needed
41+ // TODO(EvyBongers): it appears that a call to
42+ // ::LEDPaletteTheme.reserveThemes() is needed because it's where
43+ // palette_base_ gets initialized. Since this plugin (and possibly others)
44+ // don't actually use themes, requesting memory for storing themes doesn't
45+ // make much sense. Maybe initialisation of palette_base_ could be moved to a
46+ // setup() method, though maybe the palette should be split from palette
47+ // theme altogether?
4248 map_base_ = ::LEDPaletteTheme.reserveThemes (1 );
4349}
4450
You can’t perform that action at this time.
0 commit comments