Skip to content

Commit ab3227f

Browse files
committed
feat(windows): review comments
1 parent 883092e commit ab3227f

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

windows/src/desktop/kmshell/main/UfrmMain.pas

+2-2
Original file line numberDiff line numberDiff line change
@@ -797,7 +797,7 @@ procedure TfrmMain.Support_ProxyConfig;
797797
Free;
798798
end;
799799
end;
800-
// TODO: #10210 Remove Update
800+
// TODO-WINDOWS-UPDATES: #10210 Remove Update
801801
procedure TfrmMain.Support_UpdateCheck;
802802
begin
803803
with TOnlineUpdateCheck.Create(Self, True, False) do
@@ -838,7 +838,7 @@ procedure TfrmMain.Update_CheckNow;
838838

839839
procedure TfrmMain.Update_ApplyNow;
840840
var
841-
ShellPath, s: WideString;
841+
ShellPath, s: string;
842842
FResult: Boolean;
843843
begin
844844
ShellPath := TKeymanPaths.KeymanDesktopInstallPath(TKeymanPaths.S_KMShell);

windows/src/desktop/kmshell/main/initprog.pas

+1-1
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ function Init(var FMode: TKMShellMode; KeyboardFileNames: TStrings; var FSilent,
253253
else if s = '-?' then FMode := fmHelpKMShell
254254
else if s = '-h' then FMode := fmHelp
255255
else if s = '-t' then FMode := fmTextEditor
256-
//TODO: will remove -ouc not used
256+
//TODO-WINDOWS-UPDATES: will remove -ouc not used
257257
// -buc uses the Statemachine can be used for external scripts to force a check
258258
else if s = '-ouc' then FMode := fmOnlineUpdateCheck
259259
else if s = '-buc' then FMode := fmBackgroundUpdateCheck

windows/src/engine/keyman/main.pas

+3-3
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,14 @@ implementation
4040
System.Win.Registry,
4141

4242
GetOsVersion,
43+
Keyman.System.ExecutionHistory,
4344
Keyman.System.Security,
4445
Keyman.Winapi.VersionHelpers,
4546
KeymanVersion,
47+
Klog,
4648
RegistryKeys,
4749
UfrmKeyman7Main,
48-
UserMessages,
49-
Klog,
50-
Keyman.System.ExecutionHistory;
50+
UserMessages;
5151

5252
function ValidateParameters(var FCommand: Integer): Boolean; forward;
5353
function PassParametersToRunningInstance(FCommand: Integer): Boolean; forward;

0 commit comments

Comments
 (0)