Skip to content

Commit f140e40

Browse files
authored
Merge pull request #237 from khaeru/test/ilo
Address flaky TestILO.test_gh_96()
2 parents deca38f + 47970fd commit f140e40

File tree

4 files changed

+5
-3
lines changed

4 files changed

+5
-3
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ __pycache__
88
# Development and build files
99
.benchmarks
1010
.coverage*
11+
.dmypy*
1112
.mypy_cache
1213
.pytest_cache
1314
.ruff_cache

doc/whatsnew.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ Next release
1111
with lxml version 6.0.0 (`released 2025-06-26 <https://lxml.de/6.0/changes-6.0.0.html>`__)
1212
for SDMX-ML messages containing XHTML values.
1313
- Correct a broken link to :ref:`im` in the README (:pull:`233`; thanks :gh-user:`econometricsfanboy` for :issue:`232`).
14+
- Update the base URL of the :ref:`ILO <ILO>` source to use HTTPS instead of plain HTTP (:pull:`237`).
1415

1516
.. _2.22.0:
1617

sdmx/sources.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@
199199
{
200200
"id": "ILO",
201201
"name": "International Labor Organization",
202-
"url": "http://sdmx.ilo.org/rest",
202+
"url": "https://sdmx.ilo.org/rest",
203203
"headers": {
204204
"data": {
205205
"Accept": "application/vnd.sdmx.structurespecificdata+xml;version=2.1"

sdmx/tests/test_sources.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -348,13 +348,13 @@ class TestILO(DataSourceTest):
348348
"structureset": NotImplementedError, # 501
349349
}
350350

351-
@pytest.mark.network
352-
def test_gh_96(self, caplog, client):
351+
def test_gh_96(self, caplog, client_with_stored_responses) -> None:
353352
"""Test of https://github.com/khaeru/sdmx/issues/96.
354353
355354
As of 2024-02-13, the web service no longer has the prior limitations on
356355
the `references` query parameter, so the special handling is removed.
357356
"""
357+
client = client_with_stored_responses
358358
client.get("codelist", "CL_ECO", params=dict(references="parentsandsiblings"))
359359

360360
# As of 2024-02-13, no longer needed

0 commit comments

Comments
 (0)