Miscellaneous fixes for 2025-W44 #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoid versionchanged directives being formatted as params.
- Move re-construction of groupdict for match() to that function. - Type all attributes as simply str, using empty str as default. - Adjust comparisons of version to None.
Match characters other than digits and "." in version parts, per the standards.
Align with location of the tested classes in .model.common.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
==========================================
- Coverage 99.02% 98.25% -0.77%
==========================================
Files 115 115
Lines 9344 9360 +16
==========================================
- Hits 9253 9197 -56
- Misses 91 163 +72
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #251.
Closes #230.
PR checklist
Update documentationN/A, bugfix