-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some zener models are unusable #22
Comments
I think I have found where these models are coming from |
Okkk thanks! |
If that's the case then the copyright notice has been removed when importing these model into this library which is a copy right law violation I think. |
@nexx512 That is why I ended up not submitting the fix. Having them all in one place would be very nice indeed but legality of such a compendium is questionable. I'm not a lawyer and can't consult one, so I have to avoid touching this. |
@fedorkotov Good point. Unfortunately I already posted a pull request where I manually fixed some models, but only syntactically. They probably don't work for simulation. If i had read this issue before, I wouldn't have done that and stayed away from this repo. |
Some subcirquits in https://github.com/kicad-spice-library/KiCad-Spice-Library/blob/master/Models/Diode/zener.lib library have missing
.ENDS
cards andDR
models.For example these ones:
DI_BZX84C3V6T
DI_BZX84C3V6TS
DI_BZX84C3V6W
DI_BZX84C3V9S
DI_BZX84C3V9T
DI_BZX84C3V9TS
DI_BZX84C3V9W
The text was updated successfully, but these errors were encountered: