Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some zener models are unusable #22

Open
fedorkotov opened this issue Aug 25, 2021 · 5 comments
Open

Some zener models are unusable #22

fedorkotov opened this issue Aug 25, 2021 · 5 comments

Comments

@fedorkotov
Copy link

fedorkotov commented Aug 25, 2021

Some subcirquits in https://github.com/kicad-spice-library/KiCad-Spice-Library/blob/master/Models/Diode/zener.lib library have missing .ENDS cards and DR models.
For example these ones:

  • DI_BZX84C3V6T
  • DI_BZX84C3V6TS
  • DI_BZX84C3V6W
  • DI_BZX84C3V9S
  • DI_BZX84C3V9T
  • DI_BZX84C3V9TS
  • DI_BZX84C3V9W
@fedorkotov
Copy link
Author

I think I have found where these models are coming from
https://www.diodes.com/assets/Spice-Models/Discrete-Prodcut-Groups/Zener-Diodes.txt
I will submit a fix sometime later this week.

@aster94
Copy link
Contributor

aster94 commented Aug 26, 2021

Okkk thanks!

@nexx512
Copy link

nexx512 commented Dec 16, 2021

If that's the case then the copyright notice has been removed when importing these model into this library which is a copy right law violation I think.
It says that these model may be coped for research and design and that they have to be copied intact including the copyright notice.
So to avoid any possible legal issues I would suggest to copy that file completely into the repository.

@fedorkotov
Copy link
Author

@nexx512 That is why I ended up not submitting the fix. Having them all in one place would be very nice indeed but legality of such a compendium is questionable. I'm not a lawyer and can't consult one, so I have to avoid touching this.
It would be nice of course if Diodes Incorporated and others released their models with some more permissive license.

@nexx512
Copy link

nexx512 commented Dec 16, 2021

@fedorkotov Good point. Unfortunately I already posted a pull request where I manually fixed some models, but only syntactically. They probably don't work for simulation. If i had read this issue before, I wouldn't have done that and stayed away from this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants