Skip to content

Some annotations are copied/moved to the wrong file. #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geoffroy-noel-ddh opened this issue Apr 2, 2024 · 6 comments
Open

Some annotations are copied/moved to the wrong file. #52

geoffroy-noel-ddh opened this issue Apr 2, 2024 · 6 comments
Assignees
Labels
annotate bug Something isn't working

Comments

@geoffroy-noel-ddh
Copy link
Member

See examples in gh-49. Although there is not yet a way to reproduce this step by step.

@geoffroy-noel-ddh
Copy link
Member Author

geoffroy-noel-ddh commented Feb 7, 2025

Bug appeared again in #89

Possible cause

Likely scenario is that the selected annotation is not forgotten by the annotator before selecting to another inscription. Although this bug appear less often than those steps occur so there must be some more specific condition/step. Or it's a race condition. Maybe a clue is that the copied annotation is associated to another character in the text (see diagnosis in #89 ). So an additional step, maybe is that the user clicks on a free character just after having selected the new inscription.

A very likely cause is this newly found bug: #90

Detection and management

Ideally I reproduce and fix that issue. But it may not be easy to reproduce.

The good news is that this bug doesn't corrupt or lose existing annotations, it creates new ones. So the remediation suggested in #51 should at least prevent duplicates to appear in the index (and thus change-queue). Existence of duplicate would then be disruptive and could easily be cleaned up on a regular basis.

@simonastoyanova
Copy link
Collaborator

Rogue red box appeared again in 3364: https://kingsdigitallab.github.io/crossreads/annotator.html?obj=http%3A%2F%2Fsicily.classics.ox.ac.uk%2Finscription%2FISic003364&img=ISic003364.jpg&sup=0&scr=greek-1

Tagged as an circular omicron, comes from some other inscription. Still not sure how this happens or how to prevent it.

@simonastoyanova
Copy link
Collaborator

@geoffroy-noel-ddh
Copy link
Member Author

geoffroy-noel-ddh commented Mar 13, 2025

I think they are old duplicates. Predating the fix In introduced in February. It should be safe to delete them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
annotate bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants