Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLG Support? #819

Open
d3vilsown opened this issue Oct 20, 2024 · 13 comments
Open

HLG Support? #819

d3vilsown opened this issue Oct 20, 2024 · 13 comments
Labels
enhancement New feature or request

Comments

@d3vilsown
Copy link

Hey Guys, i'm using SnappierIPTV with KSPlayer for LiveTV on my Apple TV 4K 2022 tvOS 18.0. When i watch 4K Channels with HLG the TV instead triggers Dolby Vision and the Picture is very dark - is there a reason why they don't show up in HLG because the device should support it? If i try the same channels on my internal TV App they run perfectly fine in 4K HLG.
Thanks

@d3vilsown d3vilsown added the enhancement New feature or request label Oct 20, 2024
@Kimentanm
Copy link
Contributor

Yes, HLG is currently recognized as Dolby Vision @kingslay

@kingslay
Copy link
Owner

可以提供下有问题的hlg视频给我吗?我调试下

@d3vilsown
Copy link
Author

Hey, thanks for your reply - here's a sample.
https://mega.nz/file/MgQE3AJR#CxNaXvjB8L-iiXFjLaIfgQIm3KvwSqHwFPzDFle3AtM

@kingslay
Copy link
Owner

@d3vilsown 我用你发给我的视频。在我的app上播放。显示的是HLG。麻烦你在你的电视上用我的app播放一下,看下显示的是不是HLG。
Screenshot 2024-10-21 at 22 13 54

@d3vilsown
Copy link
Author

Thanks for the fast feedback, i've downloaded tracyplayer and it seems to work on my iphone 15 pro max. i'm on a business-trip rn, but will test it next weekend on my apple tv. maybe it's just a bad implementation of KSPlayer by Snappier IPTV. I'll get back to you asap.

@UnknownCoder807
Copy link

UnknownCoder807 commented Oct 21, 2024

Thanks for the fast feedback, i've downloaded tracyplayer and it seems to work on my iphone 15 pro max. i'm on a business-trip rn, but will test it next weekend on my apple tv. maybe it's just a bad implementation of KSPlayer by Snappier IPTV. I'll get back to you asap.

edit : Others have explained the issue very well. The issue is down to KSPlayer not Snappier having a bad implementation.

@cdguy
Copy link

cdguy commented Oct 21, 2024

Yes, HLG is currently recognized as Dolby Vision @kingslay

Hello @Kimentanm last year I had a conversation with Kintan regarding HLG streams displayed as HDR10, because of the bit depth value.

normally HLG streams are not supposed to be in 10 bits as it should only be used for HDR10 live streams

#685 (comment)

I think it is related.

@Kimentanm
Copy link
Contributor

Kimentanm commented Oct 21, 2024

App显示的参数是HLG,但是电视机(不是AppleTV)识别(点亮)出来的是杜比 @kingslay @cdguy

@kingslay
Copy link
Owner

App显示的参数是HLG,但是电视机(不是AppleTV)识别(点亮)出来的是杜比 @kingslay @cdguy

@Kimentanm 你可以下载下这个视频。看下你的电视机会不会显示为杜比
https://mega.nz/file/MgQE3AJR#CxNaXvjB8L-iiXFjLaIfgQIm3KvwSqHwFPzDFle3AtM

@edge261
Copy link

edge261 commented Oct 24, 2024

Apple's HLG implementation outputs HLG as HDR10.

https://forums.developer.apple.com/forums/thread/666586
https://community.firecore.com/t/support-for-hdr-hlg/46169/13

It's weird, but it is what it is. For some reason, some apps output HLG as Dolby Vision to the TV, and I also believe is down to the KSPlayer engine and not the apps... would be good to check on that, because sometimes the devs just update the engine and that causes to trigger the DV.

@benykatz1
Copy link

@d3vilsown - what is your IPTV provider? I'll check it out. (seems it's high bitrate)

@kingslay
Copy link
Owner

kingslay commented Oct 25, 2024

@Kimentanm 麻烦你在我的app的设置那边看下Device HDR Modes 里面有没有HGL。 如果没有的话,那你试下强制为preferredDisplayCriteria 设置hdr,看下效果。
就是在函数updateVideo(refreshRate: Float, isDovi: Bool, formatDescription: CMFormatDescription)里 把代码改成是
displayManager.preferredDisplayCriteria = AVDisplayCriteria(refreshRate: refreshRate, videoDynamicRange: DynamicRange.hdr.rawValue)

@kingslay
Copy link
Owner

@d3vilsown 你用我的app在你的电视上试下,播放hlg会不会点亮dovi,应该是会显示为HDR10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants