-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: decide on VERSION markers and DESTDIR #90
Comments
I sometimes |
I am for explicitly specifying DESTDIR (with its removal from |
I have the same opinion as @nvidialinuxuser . When I explicitely specify DESTDIR, I know exactly the content of |
Maybe also relevant are the implicit RUSTFLAGS, GOFLAGS, and GOPATH |
Agreed. Explicit is better than implicit. |
👍 to remove DESTDIR, RUSTFLAGS, GOFLAGS, GOPATH, and VERSION markers |
For clarification - I'm totally fine with removing the implicit environment variables, just not the VERSION markers. |
@ehawkvu Btw your use case can also be accomplished with a script that does the same thing kiss does for substituting variables but at commit-time |
@git-bruh - I don't doubt the ability of git hooks to replicate the way things currently work, but I've never intereacted with them. Have you done something similar, or a POC? @cemkeylan - What's your solution with Carbs? IIRC there was a pr/issue where you had mentioned what you do. |
I've been against this functionality since day one. It kills the entire "static" package management aspect. Instead of building such a functionality inside cpt I use some personal scripts along with m4 macros. These can be used to create boilerplate build templates (e.g. for go packages), dependencies (e.g. meson when using a meson template), and sources (such as gnome projects or Xorg software). |
DESTDIR seems mostly useless to me, but VERSION and other markers have a valid use case shown here in
kiss-xorg
: https://github.com/ehawkvu/kiss-xorg/tree/master/xorg/libXmetaIt can also be helpful to prevent patch failures if someone is using patch files to add something to
sources
andbuild
without duplicating the whole packageThe text was updated successfully, but these errors were encountered: