Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: decide on VERSION markers and DESTDIR #90

Open
git-bruh opened this issue Aug 31, 2022 · 11 comments
Open

proposal: decide on VERSION markers and DESTDIR #90

git-bruh opened this issue Aug 31, 2022 · 11 comments
Labels

Comments

@git-bruh
Copy link
Member

git-bruh commented Aug 31, 2022

DESTDIR seems mostly useless to me, but VERSION and other markers have a valid use case shown here in kiss-xorg: https://github.com/ehawkvu/kiss-xorg/tree/master/xorg/libXmeta

It can also be helpful to prevent patch failures if someone is using patch files to add something to sources and build without duplicating the whole package

@aabacchus
Copy link
Member

I sometimes curl $(cat pkg/sources); VERSION is unhelpful for this.

@ghost
Copy link

ghost commented Aug 31, 2022

I am for explicitly specifying DESTDIR (with its removal from kiss) and against MARKERS (for the reason mentioned above). But really, I don't care C:

@Vouivre
Copy link

Vouivre commented Sep 1, 2022

I have the same opinion as @nvidialinuxuser . When I explicitely specify DESTDIR, I know exactly the content of
the variable. It would be convenient with markers, but I prefer without.

@ioraff
Copy link
Member

ioraff commented Sep 8, 2022

Maybe also relevant are the implicit RUSTFLAGS, GOFLAGS, and GOPATH

@aabacchus
Copy link
Member

Maybe also relevant are the implicit RUSTFLAGS, GOFLAGS, and GOPATH

Agreed. Explicit is better than implicit.

@git-bruh
Copy link
Member Author

👍 to remove DESTDIR, RUSTFLAGS, GOFLAGS, GOPATH, and VERSION markers
👎 to keep them

@echawk
Copy link
Member

echawk commented Sep 16, 2022

For clarification - I'm totally fine with removing the implicit environment variables, just not the VERSION markers.

@git-bruh
Copy link
Member Author

@ehawkvu Btw your use case can also be accomplished with a script that does the same thing kiss does for substituting variables but at commit-time

@echawk
Copy link
Member

echawk commented Sep 18, 2022

@git-bruh - I don't doubt the ability of git hooks to replicate the way things currently work, but I've never intereacted with them. Have you done something similar, or a POC?

@cemkeylan - What's your solution with Carbs? IIRC there was a pr/issue where you had mentioned what you do.

@cemkeylan
Copy link

I've been against this functionality since day one. It kills the entire "static" package management aspect. Instead of building such a functionality inside cpt I use some personal scripts along with m4 macros. These can be used to create boilerplate build templates (e.g. for go packages), dependencies (e.g. meson when using a meson template), and sources (such as gnome projects or Xorg software).

@git-bruh
Copy link
Member Author

@kiss-community kiss-community locked and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants