Skip to content

KiteView #3

Open
Open
@xinsight

Description

@xinsight

I noticed that there is a KitePresentationViewController but no access to the containing view (KiteView?). It seems simpler and more conventional to add an animation to an existing view instead of having to deal with a nested view controller. (You also don't need to bother about retaining the view controller as a local variable.)

For example, instead of:

    guard let kitePresentationViewController = KitePresentationViewController(kiteDocument: kiteDocument) else {
        fatalError("Could not create Kite Presentation View Controller")
    }
    self.kiteViewController = kitePresentationViewController
    self.placeholderView?.addSubview(kitePresentationViewController.view)

Adding a kite animation would be:

    guard let kiteView = KiteView(with: kiteDocument) else {
        fatalError("Could not create KiteView")
    }
    self.placeholderView?.addSubview(kiteView)

Is access to the kite view on the roadmap?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions