Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline not centered #66

Open
zerox003 opened this issue Feb 28, 2023 · 7 comments
Open

Offline not centered #66

zerox003 opened this issue Feb 28, 2023 · 7 comments
Labels
help wanted Extra attention is needed

Comments

@zerox003
Copy link

Before:
vJIQUBn0

After:
UKwi2vFv

@kittinan kittinan added the help wanted Extra attention is needed label Feb 28, 2023
@zerox003
Copy link
Author

zerox003 commented Feb 28, 2023

This is caused due to the fact that the Song icon aint present any longer.
The offline text shifts to the left but the clickbox doesnt get updated.
Means the right side from the scrolling offline text is still clickable.

I believe this is more of a bug, no? @kittinan

@ntsd
Copy link
Contributor

ntsd commented Apr 10, 2023

We can try to use the flex layout in that case @kittinan .

@kittinan
Copy link
Owner

@ntsd Could you help to fix this issue?

@ntsd
Copy link
Contributor

ntsd commented Apr 11, 2023

Not sure what theme is this I think it's a customize one. @zero5enpai I suggest using flex-grow on the name, it will stretch when the cover is not found.

@zerox003
Copy link
Author

zerox003 commented Apr 12, 2023

@ntsd I'm not using a custom theme. Using the Novatorem theme atm-

@ntsd
Copy link
Contributor

ntsd commented Apr 18, 2023

@kittinan @zero5enpai Fix by this PR #67.

@zerox003
Copy link
Author

zerox003 commented Apr 18, 2023

tyvm!
The offline scroll is still kinda offset tho- ^^'
image
how about making it static or having an option for that?

ps: I switched the rows content between making that post and now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants