feat: remove huge amount flags (#591)

* fix: type passed to redirect handler

* feat: huge amount flag removed to add it as a feature

* fix: unit test fixed

Author: roger-in-kiva

@kiva/kv-components/src/utils/loanUtils.js

@@ -177,7 +177,6 @@ function buildPriceArray(amountLeft, minAmount) {
  * @param {boolean} isCompleteLoanActive Whether to include option that would complete loan
  * @param {number} minAmount The min amount to show in the dropdown
  * @param {boolean} enableFiveDollarsNotes Whether five dollar notes are enabled
- * @param {boolean} enableHugeAmount Whether huge loan amounts are enabled
  * @param {boolean} isVisitor Whether the current user is a visitor
  * @param {boolean} inPfp Whether the loan is in PFP
  * @returns {string[]} Price value array for the CTA dropdown
@@ -187,7 +186,6 @@ export function getDropdownPriceArray(
 	isCompleteLoanActive = false,
 	minAmount = 25,
 	enableFiveDollarsNotes = false,
-	enableHugeAmount = false,
 	isVisitor = true,
 	inPfp = false,
 ) {
@@ -196,7 +194,7 @@ export function getDropdownPriceArray(
 		? build5DollarsPriceArray(parsedAmountLeft).slice(0, 28)
 		: buildPriceArray(parsedAmountLeft, minAmount).slice(0, 20);
 
-	if (enableHugeAmount && parsedAmountLeft > 500 && !isVisitor) {
+	if (parsedAmountLeft > 500 && !isVisitor) {
 		const hugePriceArray = buildHugePriceArray(parsedAmountLeft);
 		priceArray = priceArray.concat(hugePriceArray);
 	}

@kiva/kv-components/src/vue/KvClassicLoanCard.vue

@@ -220,7 +220,6 @@
 				:user-balance="userBalance"
 				:get-cookie="getCookie"
 				:set-cookie="setCookie"
-				:enable-huge-amount="enableHugeAmount"
 				:is-visitor="isVisitor"
 				:primary-button-text="primaryButtonText"
 				:secondary-button-text="secondaryButtonText"
@@ -263,7 +262,6 @@
 				:get-cookie="getCookie"
 				:set-cookie="setCookie"
 				:error-msg="errorMsg"
-				:enable-huge-amount="enableHugeAmount"
 				:is-visitor="isVisitor"
 				@add-to-basket="$emit('add-to-basket', $event)"
 			/>
@@ -453,10 +451,6 @@ export default {
 			type: String,
 			default: '',
 		},
-		enableHugeAmount: {
-			type: Boolean,
-			default: false,
-		},
 		primaryButtonText: {
 			type: String,
 			default: 'Lend',

@kiva/kv-components/src/vue/KvLendCta.vue

@@ -106,8 +106,7 @@
 			>
 				<div
 					v-if="showPresetAmounts && !isAdding"
-					class="tw-flex tw-gap-1 lg:tw-gap-2"
-					:class="{'tw-flex-wrap md:tw-flex-nowrap': enableHugeAmount}"
+					class="tw-flex tw-gap-1 lg:tw-gap-2 tw-flex-wrap md:tw-flex-nowrap"
 				>
 					<template v-if="!isLendAmountButton">
 						<kv-ui-button
@@ -126,11 +125,10 @@
 						v-if="showFilteredDropdown"
 						:id="`LoanAmountDropdown_${loanId}`"
 						v-model="selectedDropdownOption"
-						class="tw-min-w-12 tw-rounded filtered-dropdown"
+						class="tw-min-w-12 tw-rounded filtered-dropdown tw-w-full"
 						:class="{
 							'unselected-dropdown': !selectedDropdown,
 							'selected-dropdown': selectedDropdown,
-							'tw-w-full': enableHugeAmount
 						}"
 						aria-label="Lend amount"
 						@update:modelValue="trackLendAmountSelection"
@@ -327,10 +325,6 @@ export default {
 			type: Boolean,
 			default: false,
 		},
-		enableHugeAmount: {
-			type: Boolean,
-			default: false,
-		},
 		isVisitor: {
 			type: Boolean,
 			default: true,
@@ -416,7 +410,6 @@ export default {
 				this.isCompleteLoanActive,
 				minAmount,
 				this.enableFiveDollarsNotes,
-				this.enableHugeAmount,
 				this.isVisitor,
 			);
 			// Limit price options based on the maxAmount

@kiva/kv-components/src/vue/KvLoanActivities.vue

@@ -65,7 +65,6 @@
 						:basket-items="basketItems"
 						:route="route"
 						:is-adding="isAdding"
-						:enable-huge-amount="enableHugeAmount"
 						:is-visitor="isVisitor"
 						:enable-five-dollars-notes="enableFiveDollarsNotes"
 						@add-to-basket="$emit('add-to-basket', $event)"
@@ -180,10 +179,6 @@ export default {
 			type: Boolean,
 			default: false,
 		},
-		enableHugeAmount: {
-			type: Boolean,
-			default: false,
-		},
 		isVisitor: {
 			type: Boolean,
 			default: true,

@kiva/kv-components/src/vue/KvWideLoanCard.vue

@@ -215,7 +215,6 @@
 					:user-balance="userBalance"
 					:get-cookie="getCookie"
 					:set-cookie="setCookie"
-					:enable-huge-amount="enableHugeAmount"
 					:is-visitor="isVisitor"
 					class="tw-mt-auto tw-self-end"
 					:class="{'tw-flex-grow' : !sharesAvailable, 'tw-flex-shrink-0' : sharesAvailable}"
@@ -375,10 +374,6 @@ export default {
 			type: Array,
 			default: () => ([]),
 		},
-		enableHugeAmount: {
-			type: Boolean,
-			default: false,
-		},
 	},
 	setup(props, { emit }) {
 		const {

@kiva/kv-components/src/vue/stories/KvClassicLoanCard.stories.js

@@ -387,7 +387,6 @@ export const HugeLentAmount = story({
 	kvTrackFunction,
 	photoPath,
 	isVisitor: false,
-	enableHugeAmount: true,
 });
 
 export const SupportButton = story({

@kiva/kv-components/src/vue/stories/KvLendCta.stories.js

@@ -84,7 +84,6 @@ export const HugeAmount = story({
 	},
 	unreservedAmount: '12850.00',
 	kvTrackFunction,
-	enableHugeAmount: true,
 	isVisitor: false,
 });
 
@@ -95,7 +94,6 @@ export const HugeAmountUnder1000 = story({
 	},
 	unreservedAmount: '850.00',
 	kvTrackFunction,
-	enableHugeAmount: true,
 	isVisitor: false,
 });
 
@@ -320,7 +318,6 @@ export const WithPresetOptionsHugeAmount = story({
 	},
 	unreservedAmount: '12850.00',
 	kvTrackFunction,
-	enableHugeAmount: true,
 	isVisitor: false,
 	showPresetAmounts: true,
 });

@kiva/kv-components/src/vue/stories/KvWideLoanCard.stories.js

@@ -292,5 +292,4 @@ export const HugeLentAmount = story({
 	kvTrackFunction,
 	photoPath,
 	isVisitor: false,
-	enableHugeAmount: true,
 });

@kiva/kv-components/tests/unit/specs/utils/loanUtils.spec.js

@@ -332,7 +332,7 @@ describe('loanUtils', () => {
 		});
 
 		it('should return huge dropdown values between 500 and 1000', () => {
-			const result = getDropdownPriceArray('650.00', false, 25, false, true, false);
+			const result = getDropdownPriceArray('650.00', false, 25, false, false);
 
 			expect(result).toEqual([
 				'25',
@@ -361,7 +361,7 @@ describe('loanUtils', () => {
 		});
 
 		it('should return huge dropdown values up to 10,000', () => {
-			const result = getDropdownPriceArray('11000.00', false, 25, false, true, false);
+			const result = getDropdownPriceArray('11000.00', false, 25, false, false);
 
 			expect(result).toEqual([
 				'25',
@@ -402,7 +402,7 @@ describe('loanUtils', () => {
 		});
 
 		it('should return not huge dropdown values for visitor', () => {
-			const result = getDropdownPriceArray('650.00', false, 25, false, true, true);
+			const result = getDropdownPriceArray('650.00', false, 25, false, true);
 
 			expect(result).toEqual([
 				'25',