Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

black line at the bottom of cropped image #17

Open
r00dY opened this issue Sep 2, 2012 · 2 comments
Open

black line at the bottom of cropped image #17

r00dY opened this issue Sep 2, 2012 · 2 comments

Comments

@r00dY
Copy link

r00dY commented Sep 2, 2012

Hi,

I think I've found a bug.

When I upload an image with resolution 740/527, and cropping min width/height is also 740/527, the cropped and resized image (mode 5 of modified JIT) shows with a 1-pixel black line at the bottom. This extension is very important to me (I must release a page in couple of days). Could you check if this happens to you as well?

If you have no time, I will look into your code to fix this, however, I think it can be quite complex.

Cheers!

@klaftertief
Copy link
Collaborator

Sounds like a rounding issue. Will have a look at it soonish.

(But why would you want to crop an image to its full dimensions?)

@r00dY
Copy link
Author

r00dY commented Sep 2, 2012

I see what's going on. The uploaded image is 740/527, but image cropper somehow outputs cropped height as 528. And this 1 pixel of difference is this black line.

I very often must crop an image to its full dimensions. The classic example is when I have to CMSify a page which is online but have no CMS yet. All images are cropped by front-end developer already and I have to insert them into CMS and crop to the full dimensions, because... they are already cropped :) The cropper is useful only for images uploaded by end-user after CMS is done. Simple ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants