Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust source list-types to not require cluster admin permissions when using -oyaml #1385

Open
mgencur opened this issue Jul 14, 2021 · 3 comments
Labels
kind/feature New feature or request triage/accepted Issues which should be fixed (post-triage)

Comments

@mgencur
Copy link
Contributor

mgencur commented Jul 14, 2021

Feature request

Currently, running kn source list-types -oyaml requires cluster admin permissions as it works with CustomResourcesDefinition and CurtomResourceDefinitionList.
The goal is to fix/adjust this command to not require cluster admin permissions.

Related to discussions in #1384

Use case

  • A user or project admin can list available source types without requiring cluster admin permissions.

UI Example


@mgencur mgencur added the kind/feature New feature or request label Jul 14, 2021
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 13, 2021
@mgencur
Copy link
Contributor Author

mgencur commented Oct 19, 2021

/reopen

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 20, 2021
@rhuss
Copy link
Contributor

rhuss commented Nov 4, 2021

That's a tricky one, as there is currently no alternative to examine CRDs. We could examine deployments for source-related labels, but this will then only the types for which a source has been already created. We hoped to leverage the DiscoveryApi that would collect the available sources into an CR's status that we then can evaluate (the discovery-api controller is supposed to be able to read CRDs), but it looks like that work on the Discovery API has been stalled.

Maybe for now we should just print out a nicer error message is the type can not be listed ? Happy for any other ideas how to fix this, of course.

@rhuss rhuss added the triage/accepted Issues which should be fixed (post-triage) label Jan 4, 2022
@rhuss rhuss moved this to Icebox in Client Planning Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request triage/accepted Issues which should be fixed (post-triage)
Projects
Status: Backlog
Development

No branches or pull requests

2 participants